mirrors/arti.git/crates/tor-hscrypto/src/macros.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2025-07-23T15:31:30Ztor-hscrypto: fix typos2025-07-23T15:31:30Ztcyrus4027-tcyrus@gitlab.torproject.org2025-06-26T21:18:47Zurn:sha1:8150a93956daec49663927e5e784765211f3e26ahscrypto: Downgrade a TODO HSS comment.2024-01-15T02:03:08ZNick Mathewsonnickm@torproject.org2024-01-15T02:03:08Zurn:sha1:d6eb88943cc0b7874cd1dc42e00c2ef7faae7727
This is not a blocker; it's just a code movement or duplication
issue IIUC.
Convert to the latest versions of dalek-cryptography2023-11-29T15:34:58ZNick Mathewsonnickm@torproject.org2023-11-21T15:58:29Zurn:sha1:98037a2c788bd901679139178d25f855324637f3
The main changes that we have to adjust for are as follows:
* In x25519-dalek:
* `StaticSecret` is now behind a feature.
* `StaticSecret::new` is deprecated in favor of
`StaticSecret::random_from_rng`.
* StaticSecret no longer does its own clamping.
* In ed25519-dalek:
* `SecretKey` has (in effect) been renamed to `SigningKey`. The name
`SecretKey` is now an alias for `[u8; 32]`.
* `SigningKey` is effectively a keypair, since it contains a
public key as well.
* `PublicKey` has been renamed to `VerifyingKey`.
* The functions to extract a signing key and verifying key have
been renamed as you might expect.
* `ExpandedSecretKey` has been moved to `hasmat` and no longer
implements `sign`.
* `ExpanededSecretKey` now has as its elements a scalar and a hash
prefix.
* Various functions that took `&[u8]` now take `&[u8; N]`.
* We no longer need a wrapper for older versions of rand.
There is a single test in tor-keymgr that does not pass. I've
marked it as ignore for now, in hopes that @gabi-250 can help me
figure it out.
This closes #808. There are several changes I want to make before
we merge, however. They are marked with TODO DALEK.
tor-hscrypto: Add a TODO re re-implementation of x25519 keypair gen2023-11-23T17:30:44ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-23T17:24:27Zurn:sha1:2193268fb102ae7deebfc010f7fd1f16621dae43
IMO it is quite undesirable to have multiple copies of "gen a secret
key and make a keypair out of it". Add a TODO HSS and and a ref to
arti#1137 which is related.
tor-hscrypto: Add a docs TODO re the define_pk_keypair macro2023-11-23T17:29:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-23T17:12:24Zurn:sha1:8f95a1cd1c3166534735704ca1115c32ebd540d5tor-hscrypto: Define Keypair conversions for all curve25519 newtypes2023-11-23T17:29:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-23T14:54:10Zurn:sha1:8406d0d76ee3ed4d82121195c806f77a45dd7de8
1. Move `impl From<SpecificKeypair> for curve25519::StaticKeypair`
(which was just a bespoke impl for HsClientDescEncKeypair)
into the define_pk_keypair macro, so everything has it.
Currently the only other user of the curve25519_pair feature is HsSvcNtorKey.
2. Provide the reverse conversion too.
tor-hsservice: Add HsClientDescEncKeypair.2023-09-25T18:56:51ZGabriela Moldovangabi@torproject.org2023-09-25T15:24:14Zurn:sha1:66ea8c9f4af825858535dc7fb0c3e8bf7bc83840hs_ntor: Take our k_hss_ntor keypair explicitly.2023-09-20T14:26:14ZNick Mathewsonnickm@torproject.org2023-09-20T14:26:14Zurn:sha1:b6b8fe7effc8071e8e73ccb63837772ad0d9169ator-crypto: Fix some derive formatting2023-09-18T11:28:11ZIan Jacksonijackson@chiark.greenend.org.uk2023-09-18T10:57:30Zurn:sha1:220d5d78f70d80d6b1c7d0bb364ab4eecd630f37
This was missing the conventional spaces. Noticed in passing.
hscrypto: Define a keypair type for HsSvcNtor{,Secret}Key2023-09-17T14:58:16ZNick Mathewsonnickm@torproject.org2023-09-12T20:16:05Zurn:sha1:86eea3351856bc93af5bd5ed3d1baede2abefaa2
(Also, extend our macro so that we can wrap other curve25519 keys in
this way, if we want.)