mirrors/arti.git/crates/tor-hsclient/src, branch arti-v2.5.1

tor-hsclient: connect.rs: Remove a redundant map_err

2026-07-23T10:13:55Z

HsDesc::parse_decrypt_validate: Don't check validity time

2026-07-23T10:13:54Z

This function returns a `TimeRangeBound`. That implies a responsibility on the caller to check the time. It doesn't make sense for this function to do the check as well. But, it turns out that in tor-hsclient, the `TimeRangeBound` is sometimes processed with `.dangerously` on the assumption that it was checked earlier. I considered changing this, and storing plain `HsDesc` and a separate `TimeRange` - but that's not right, because there are places where the `TimeRangeBound` is used well after it was verified. Instead, in this commit, I (effectively) move the `.check_valid_at` call from `parse_decrypt_validate` to its principal call site. This involves a change to the error representation. Previously, validity time errors ended up as `DescriptorErrorDetail::Descriptor` containing an `HsDescError::OuterValidation` HsDescError:: InnerValidation`, which in turn contains a `tor_netdoc::Error`. (`tor_netdoc::Error` is a rather awkward type.) Now we have our own error variant. The overall behaviour is unchanged.

clippy config: Forbid TimeRangeBound::if_valid_now

2026-07-23T10:13:34Z

tor-checkable: Rename `TimeBound::check_valid_` to `if_valid_`

2026-07-23T10:13:34Z

I find these names confusing. To my mind "check" implies a function returning `Result<(), _>`. Some other APIs use `unwrap` here but I think `if` is good.

tor-checkable: TimeRangeBound: Rename bounds to bounds_start_end

2026-07-23T10:13:34Z

This just returns a tuple. We're going to introduce a new method that returns a `TimeRagne` and will want to be called `bounds`. That method will want to be in the `TimeBound` trait, but for now we add it here. Various call sites will be added in forthcoming commits.

Use new TimeRangeBound name throughout the tree

2026-07-16T15:47:50Z

Use new TimeBound name throughout the tree

2026-07-16T15:47:50Z

Remove now-unneeded allow(clippy::cognitive_complexity)

2026-07-15T18:05:29Z

add_warning: add reference to arti#2556

2026-07-15T17:56:49Z

Removed unnecessary lint

2026-07-15T17:16:51Z

Removed unnecessary lint

mirrors/arti.git/crates/tor-hsclient/src, branch arti-v2.5.1

tor-hsclient: connect.rs: Remove a redundant map_err

HsDesc::parse_decrypt_validate: Don't check validity time

clippy config: Forbid TimeRangeBound::if_valid_now

tor-checkable: Rename `TimeBound::check_valid_*` to `if_valid_*`

tor-checkable: TimeRangeBound: Rename bounds to bounds_start_end

Use new TimeRangeBound name throughout the tree

Use new TimeBound name throughout the tree

Remove now-unneeded allow(clippy::cognitive_complexity)

add_warning: add reference to arti#2556

Removed unnecessary lint

tor-checkable: Rename `TimeBound::check_valid_` to `if_valid_`