mirrors/arti.git/crates/tor-hsclient/src, branch arti-v1.4.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.42025-05-29T14:21:17Z*: suppress cognitive_complexity warnings from nightly2025-05-29T14:21:17ZNick Mathewsonnickm@torproject.org2025-05-21T14:48:35Zurn:sha1:5327d3e22a83b8469a5d4191d92e1364344ddc93
Apparently clippy nightly is better (or worse?) about detecting
complex functions than before, so I'm suppressing these warnings
where they occur.
I have mixed feelings about these warnings: On the plus side,
they really do help to detect functions that are twistier than they
need to be. On the minus side, they get confused by tracing macros,
and the "allows" do pile up. But on the plus side, those "allows"
do provide a way to find functions that need to be refactored,
and they are never uglier than the functions they decorate.
Include "bug" in all bug error messages2025-04-28T14:06:57ZNick Mathewsonnickm@torproject.org2025-04-28T14:06:57Zurn:sha1:aa813e37c94898ed621eb259b67754f1e70a67bbprotover, *: Add documentation about what "supported" means.2025-04-16T23:06:51ZNick Mathewsonnickm@torproject.org2025-04-14T00:42:31Zurn:sha1:11148719ba04aab37c7784d198018eeacced69c2Add warnings about removing supported protocols.2025-04-16T23:06:51ZNick Mathewsonnickm@torproject.org2025-04-07T15:27:42Zurn:sha1:ba612260ae603c8e5eba37206c21fd089afe075dNew functions to report supported subprotocols2025-04-16T23:06:51ZNick Mathewsonnickm@torproject.org2025-04-02T18:00:00Zurn:sha1:efe36d15de88ec5b7f39db99f9d2a58e4e5db7ac
Part of #1849.
Note that these functions are distributed across crates,
so that if (in the future) we stop doing API breaks
with every release, we will get the right outputs.
Note also that these functions build the list of protocols
out of specific symbolic features, rather than numbers:
this makes it easier to avoid errors about "which feature was
Relay=4 again", and easier to avoid accidentally referring to a
protocol that doesn't exist, like "Consensus" (should be "Cons")
or "HsDir" (case is wrong).
fix `clippy::unneeded_struct_pattern`2025-04-03T17:32:58ZSteven Engleropara@torproject.org2025-04-03T17:30:13Zurn:sha1:5395b385584599ee6a0f8fc005ded81910d60f4b
Example:
```text
warning: struct pattern is not needed for a unit variant
--> crates/hashx/src/program.rs:165:32
|
165 | Instruction::Target { .. } => Opcode::Target,
| ^^^^^^^ help: remove the struct pattern
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern
note: the lint level is defined here
--> crates/hashx/src/lib.rs:9:9
|
9 | #![warn(clippy::all)]
| ^^^^^^^^^^^
= note: `#[warn(clippy::unneeded_struct_pattern)]` implied by `#[warn(clippy::all)]`
```
squash! Upgrade rand dependency to 0.9.2025-03-18T16:09:44ZNick Mathewsonnickm@torproject.org2025-03-18T14:47:35Zurn:sha1:895bc807f106e359d35522a3ad5f288ba6cf6a9c
- The Rng::gen() functions have been renamed to Rng::random().
squash! Upgrade rand dependency to 0.9.2025-03-18T16:09:44ZNick Mathewsonnickm@torproject.org2025-03-18T13:01:31Zurn:sha1:2f8993c22c2b86010e4fd8b5169ef0ab83f8c754
- `rand::thread_rng()` has been deprecated and renamed to `rand::rng()`
Always use full path to rand::thread_rng().2025-03-18T16:09:44ZNick Mathewsonnickm@torproject.org2025-03-18T13:00:23Zurn:sha1:30f27c7f8f8028f833ea7e84a034f2416afd447b
This is partly for consistency, and partly to facilitate
a global search-and-replace.
tor-rtmock: allow-Decorate every use of MockSleepProvider2025-03-06T17:18:52ZIan Jacksonijackson@chiark.greenend.org.uk2025-03-06T16:57:21Zurn:sha1:a4054ed0d51e7c55946bde3c247190c9bbeef6fb
MockSleepProvider and MockSleepRuntime have been declared deprecated
by the docs for some time. We're about to mark them `#[deprecated]`.
This commit has been split out for clarity of review.