mirrors/arti.git/crates/tor-hsclient/src, branch arti-v1.1.7 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.7 2023-07-24T12:46:05Z Run cargo +nightly fmt to format many let ... else ... 2023-07-24T12:46:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-24T12:46:05Z urn:sha1:3e2a909707acf7cad2621316a51f8643f1fe908a rustfmt has grown opinions about how let ... else ... ought to be formatted. They don't always agree with our previous manual decisions. I think our policy is to always insist on rustfmt. When that version of rustfmt hits stable, our CI will start to fail for everyone. (Right now this discrepancy just causes trouble for contributors who are using nightly by default.) Fix typos 2023-07-22T07:10:34Z Dimitris Apostolou dimitris.apostolou@icloud.com 2023-07-22T07:10:34Z urn:sha1:947ddfff0cfac3fef0e3d7ebc14182c638a1d90b retry-error: Attempts must be AsRef<dyn Error>; print their sources 2023-07-19T13:16:13Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-18T12:07:39Z urn:sha1:36b9d11ecb122e1ea82a13fa963c35e023f14d3a The effect is that everywhere a RetryError is used, the error sources for the contained errors will be Display'd. In tor-hsclient we no longer need to explicitly wrap things up in tor_error::Report. Merge branch 'clippy-allow' into 'main' 2023-07-11T09:37:42Z Ian Jackson iwj@torproject.org 2023-07-11T09:37:42Z urn:sha1:3acc2af4f3411588f80669ae1980679dd260b119 clippy: Allow some of our existing code patterns See merge request tpo/core/arti!1396 Merge branch 'conversation' into 'main' 2023-07-10T13:14:11Z Alexander Færøy ahf@torproject.org 2023-07-10T13:14:11Z urn:sha1:6be6352b987851f2b15d8d8f1a088924ca7b2d9c Overhaul send_control_message See merge request tpo/core/arti!1367 Merge branch 'recurse' into 'main' 2023-07-10T13:13:31Z Alexander Færøy ahf@torproject.org 2023-07-10T13:13:31Z urn:sha1:943c12739d7a67ca31a2507383a1d9a3c70a65ed tor-hsclient: Mock traits: Work around an async boobytrap See merge request tpo/core/arti!1365 Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Add exceptions for some cases of diverging_sub_expression 2023-07-10T11:33:21Z Nick Mathewson nickm@torproject.org 2023-07-07T18:17:52Z urn:sha1:0b6cc7ba5ed6962bb6cf568a8bdc788de4c329f6 See here for documentation on the lint: https://rust-lang.github.io/rust-clippy/master/index.html#/diverging_sub_expression The issue here, from what I can tell, is that the lint triggers whenever you use a diverging expression as a function body within an Throughout: Use *_report!() macros for reporting Errors. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. Run add_warning to remove `missing_panics_doc` deny. 2023-07-06T18:32:23Z Nick Mathewson nickm@torproject.org 2023-07-06T18:32:23Z urn:sha1:03f9f9987a7ba42368d82363bef7f569e32ffe2c Closes #950.