mirrors/arti.git/crates/tor-hsclient/src/state.rs, branch ios-sqlite-hacks mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks 2023-09-18T09:36:11Z tor-hsclient: expiry tests: Use advance_by 2023-09-18T09:36:11Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-13T13:59:05Z urn:sha1:cde268bb15f86869c41d436f36936abafdadcaa5 tor-hsclient: expiry: Fix a boundary error in time calculation 2023-09-18T09:36:11Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-13T16:22:37Z urn:sha1:df7ae242dc93f53e28323b4ea90b81840b249e0e We might loop, sleeping for zero. In real life this wouldn't last long, but with the mock executor it can busy loop. Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Run cargo +nightly fmt to format many let ... else ... 2023-07-24T12:46:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-24T12:46:05Z urn:sha1:3e2a909707acf7cad2621316a51f8643f1fe908a rustfmt has grown opinions about how let ... else ... ought to be formatted. They don't always agree with our previous manual decisions. I think our policy is to always insist on rustfmt. When that version of rustfmt hits stable, our CI will start to fail for everyone. (Right now this discrepancy just causes trouble for contributors who are using nightly by default.) Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Throughout: Use *_report!() macros for reporting Errors. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. tor-hsclient: Abolish ad-hoc real-world-time sleeps 2023-07-06T14:14:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-05T10:47:38Z urn:sha1:bc63fdb34c2bb910a3d0ed38a8c6378ded4230c2 Now we can reliably wait precisely for the tasks to be all waiting. This test case no longer involves any real executor. tor-hsclient: Reimplement Debug for MockCirc 2023-06-29T15:11:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-28T10:03:35Z urn:sha1:2b2ecfbb3916bedcdadff50654be78477a62b5d5 This is less code. Also it now dumps the connect_called field which was introduced in the meantime. HS configuration: Plumb configuration through (fmt) 2023-06-28T12:32:54Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-26T11:59:28Z urn:sha1:a0b6f34e42ad9098c95c9ab532efcb0bc379f290 Apply deferred rustfmt churn. HS configuration: Plumb configuration through 2023-06-28T12:32:54Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-23T16:22:41Z urn:sha1:984652217a6d8b0c82c47a418531eb4112a4695c Invent a trait a la circmgr config for the hs client connector config. Plumb a suitable value all the way through to the code that will use it.