mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.13 2023-11-29T15:34:58Z 2023-11-29T15:34:58Z Nick Mathewson nickm@torproject.org 2023-11-21T15:58:29Z urn:sha1:98037a2c788bd901679139178d25f855324637f3 The main changes that we have to adjust for are as follows: * In x25519-dalek: * `StaticSecret` is now behind a feature. * `StaticSecret::new` is deprecated in favor of `StaticSecret::random_from_rng`. * StaticSecret no longer does its own clamping. * In ed25519-dalek: * `SecretKey` has (in effect) been renamed to `SigningKey`. The name `SecretKey` is now an alias for `[u8; 32]`. * `SigningKey` is effectively a keypair, since it contains a public key as well. * `PublicKey` has been renamed to `VerifyingKey`. * The functions to extract a signing key and verifying key have been renamed as you might expect. * `ExpandedSecretKey` has been moved to `hasmat` and no longer implements `sign`. * `ExpanededSecretKey` now has as its elements a scalar and a hash prefix. * Various functions that took `&[u8]` now take `&[u8; N]`. * We no longer need a wrapper for older versions of rand. There is a single test in tor-keymgr that does not pass. I've marked it as ignore for now, in hopes that @gabi-250 can help me figure it out. This closes #808. There are several changes I want to make before we merge, however. They are marked with TODO DALEK. 2023-11-20T12:52:51Z Gabriela Moldovan gabi@torproject.org 2023-11-20T12:34:24Z urn:sha1:15c6f483e48d0cd8acf7de4d8259be183d0a5ac8 2023-10-03T15:35:14Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-22T15:13:25Z urn:sha1:9651f5ea5f046b649b17273f948e359588115332 For now we do this by changing the meaning of the name `MockSleepProvider` in runtime.rs. This is a bodge to reduce noise in this diff. Consequences at call sites: * If the type is named somehow, the other type must be used. * SimpleMockTimeProvider calls it jump_wallclock rather than jump_to, which is IMO a better name. (MockRuntime will change in a moment.) * SimpleMockTimeProvider's advance() function isn't async and doesn't yield. But none of the call sites actually mind that. 2023-09-20T13:38:25Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-20T13:32:07Z urn:sha1:aefffcf8b6bb2baab271044ab0f74a05b9a3a501 See https://gitlab.torproject.org/tpo/core/arti/-/issues/1040 2023-09-18T09:36:11Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-13T13:59:05Z urn:sha1:cde268bb15f86869c41d436f36936abafdadcaa5 2023-09-18T09:36:11Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-13T16:22:37Z urn:sha1:df7ae242dc93f53e28323b4ea90b81840b249e0e We might loop, sleeping for zero. In real life this wouldn't last long, but with the mock executor it can busy loop. 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac 2023-07-24T12:46:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-24T12:46:05Z urn:sha1:3e2a909707acf7cad2621316a51f8643f1fe908a rustfmt has grown opinions about how let ... else ... ought to be formatted. They don't always agree with our previous manual decisions. I think our policy is to always insist on rustfmt. When that version of rustfmt hits stable, our CI will start to fail for everyone. (Right now this discrepancy just causes trouble for contributors who are using nightly by default.) 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949.