mirrors/arti.git/crates/tor-hsclient/src/err.rs, branch arti-v2.5.1

HsDesc::parse_decrypt_validate: Don't check validity time

2026-07-23T10:13:54Z

This function returns a `TimeRangeBound`. That implies a responsibility on the caller to check the time. It doesn't make sense for this function to do the check as well. But, it turns out that in tor-hsclient, the `TimeRangeBound` is sometimes processed with `.dangerously` on the assumption that it was checked earlier. I considered changing this, and storing plain `HsDesc` and a separate `TimeRange` - but that's not right, because there are places where the `TimeRangeBound` is used well after it was verified. Instead, in this commit, I (effectively) move the `.check_valid_at` call from `parse_decrypt_validate` to its principal call site. This involves a change to the error representation. Previously, validity time errors ended up as `DescriptorErrorDetail::Descriptor` containing an `HsDescError::OuterValidation` HsDescError:: InnerValidation`, which in turn contains a `tor_netdoc::Error`. (`tor_netdoc::Error` is a rather awkward type.) Now we have our own error variant. The overall behaviour is unchanged.

hsclient: Support protocol negotiation for CGO and flowctrl-cc

2026-07-02T14:37:13Z

hsclient: Rate-limit HsDir re-querying

2026-05-07T18:11:56Z

Because we now refetch HsDirs on introduce NACK, we need some type of rate-limiting to prevent clients from hammering the HsDirs if the service is offline. This rate-limiting is per-HsDir: the client will avoid querying the same HsDir more frequently than `hs_dir_requery_period`. The HsDir requery info is stored in the new `DataHsDirs` map. Part of #966

hsclient: Move and correct timeouts for hsdescriptor downloads.

2026-05-07T12:33:03Z

The hspool operations already include their own timeouts, so we don't need to recalculate them. For the directory related operations, we now calculate the timeouts based on actual circuit lengths, and use those timeouts on the operations themselves.

tor-hsclient: Report IPT index in IntroductionFailed.

2025-11-25T22:55:38Z

This would have made #2268 clearer to me.

Switch Cargo.toml files to edition 2024.

2025-08-07T15:28:36Z

First, run ``` git grep -l "^edition =" | xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;' ``` Second, manually verify that all Cargo.toml files have changed, and nothing else has changed. Third, run cargo fmt again.

hs*: Define some HsDesc errors as _suspicious_.

2025-07-10T13:41:48Z

These errors are suspicious as hsdir inflation attacks, in the context of prop360.

dirclient: New error type for too-long headers.

2025-07-10T13:41:48Z

(This was previously called a parse error, which isn't right.)

hs-pow: Use TimerangeBound for puzzle parameters.

2024-10-09T16:05:21Z

Co-authored-by: Micah Elizabeth Scott

Upgrade to derive_more version 1.0.0

2024-09-25T14:37:18Z

The `derive_more` crate broke backward compatibility with this version, so this change involved quite a few manual fixups. With luck, they'll keep compatibility for some while in the future.