mirrors/arti.git/crates/tor-hsclient/src/connect.rs, branch arti-v2.5.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.0 2026-06-09T15:36:01Z maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. Upgrade rand crates to 0.10. 2026-05-12T20:55:43Z Wesley Aptekar-Cassels me@wesleyac.com 2026-05-07T20:06:21Z urn:sha1:a18167928901d8c88cd1cdd87346de8ad1ee42a2 When the circ-padding feature is enabled, we use maybenot, which does not yet support rand 0.10. In the meantime, enabling this feature pulls in rand 0.9. This is not ideal, but should be okay as a temporary situation. This also replaces the use of ReseedingRng (which was removed in 0.10) with the reseeding_rng crate. This is somewhat less performant, but it should be okay. hsclient: s/cur_revision/stored_revision for clarity 2026-05-07T18:12:14Z Gabriela Moldovan gabi@torproject.org 2026-05-06T15:39:30Z urn:sha1:992b842e784f5b65a9047f5f52b1d3b2509c7347 "Stored" is more accurate than "current". hsclient: Compare the time periods instead of the blinded HsIds 2026-05-07T18:12:07Z Gabriela Moldovan gabi@torproject.org 2026-05-06T15:38:18Z urn:sha1:4f5cf0169814bacc0da45054fc9d7f36c8fe870a The blinded HsIds were used a proxy for the time periods, but it's better to just compare the TPs directly. Part of #966 hsclient: Store the current time period in a variable (fmt) 2026-05-07T18:12:07Z Gabriela Moldovan gabi@torproject.org 2026-05-06T15:41:00Z urn:sha1:4f3d02b7b57e90bc9f567e09944ff45496ce6ef8 hsclient: Store the current time period in a variable 2026-05-07T18:12:07Z Gabriela Moldovan gabi@torproject.org 2026-05-06T15:31:13Z urn:sha1:2766144c8798ba0a4ad93097d1d34a1d73b6d8ea This will soon need to be copied into `HsDescForTp`. hsclient: Fix an off-by-one check 2026-05-07T18:12:07Z Gabriela Moldovan gabi@torproject.org 2026-05-01T16:30:35Z urn:sha1:7f65a2c550b061cf14477fe04d992fa70c54b9d9 We no longer consider the HsDir rate-limited if its `requery == now`. This was caught by the new tests. hsclient: Add test for introduction retries after intro NACK 2026-05-07T18:12:07Z Gabriela Moldovan gabi@torproject.org 2026-05-01T16:18:03Z urn:sha1:12ab68ec8ea675c07e0ee2179820c33d36a3f85b hsclient: Add scope around mutex guard (fmt) 2026-05-07T18:12:07Z Gabriela Moldovan gabi@torproject.org 2026-05-01T15:26:34Z urn:sha1:f3bc3a3433703f6eb01021bbe995ff581185a910 hsclient: Add scope around mutex guard 2026-05-07T18:12:07Z Gabriela Moldovan gabi@torproject.org 2026-05-01T15:25:44Z urn:sha1:8854b4c875e951f2a48de6da51c2196d3480e811 This needs to be dropped before the next test (because the test will try to acquire the lock inside the `Mocks` impl).