mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.7 2023-08-01T14:57:55Z 2023-08-01T14:57:55Z Nick Mathewson nickm@torproject.org 2023-08-01T14:57:55Z urn:sha1:3acdf102c705314aec63679e97240bb7d981d1c8 These crates are at version 0.x.y, so we don't need to distinguish new-feature changes from other changes: ``` tor-basic-utils fs-mistrust tor-error tor-geoip tor-checkable tor-linkspec tor-netdoc tor-netdir tor-persist tor-ptmgr tor-hsservice ``` This crate has a breaking change, but only when the semver-breaking feature `experimental-api` is enabled: ``` tor-config ``` This crate is at version 1.x.y, but has no new public APIs, and therefore does not need a minor version bump: ``` arti ``` 2023-08-01T14:51:25Z Nick Mathewson nickm@torproject.org 2023-08-01T14:51:25Z urn:sha1:6f2ae5960393b64c1d7615d2d523e050d3bebe5a These crates had first-order breaking changes: ``` retry-error tor-keymgr tor-proto tor-hsclient tor-rtmock ``` Additionally, these broke because they re-exposed RetryError: ``` tor-circmgr ``` Additionally, these broke because they may re-expose something from tor-proto: ``` arti-client tor-chanmgr tor-dirclient tor-dirmgr tor-guardmgr ``` Additionally, these broke for other fiddly reasons: `tor-ptmgr` implements traits from tor-chanmgr, which has a breaking change above. `arti-hyper` exposes types from arti-client in its API. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. 2023-06-30T12:42:21Z Nick Mathewson nickm@torproject.org 2023-06-30T12:42:21Z urn:sha1:de13a7319b7de5a336a70f128d1904954ed77f82 Done with the commands below. The following crates have had various changes, and should get a patchlevel bump. Since they are pre-1.0, we do not need to distinguish new APIs from other changes. ``` cargo set-version --bump patch -p arti-client cargo set-version --bump patch -p safelog cargo set-version --bump patch -p tor-bytes cargo set-version --bump patch -p tor-cert cargo set-version --bump patch -p tor-circmgr cargo set-version --bump patch -p tor-config cargo set-version --bump patch -p tor-consdiff cargo set-version --bump patch -p tor-dirclient cargo set-version --bump patch -p tor-dirmgr cargo set-version --bump patch -p tor-error cargo set-version --bump patch -p tor-hsservice cargo set-version --bump patch -p tor-linkspec cargo set-version --bump patch -p tor-llcrypto cargo set-version --bump patch -p tor-netdir cargo set-version --bump patch -p tor-netdoc cargo set-version --bump patch -p tor-proto cargo set-version --bump patch -p tor-rpcbase cargo set-version --bump patch -p tor-socksproto ``` This crate has new features, but no new non-experimental Rust APIs. So even though it is post-1.0, it gets a patchlevel bump. ``` cargo set-version --bump patch -p arti ``` 2023-06-30T12:38:16Z Nick Mathewson nickm@torproject.org 2023-06-30T12:38:16Z urn:sha1:65e81bf0ca876669a15943caf4cf388515366623 Done with: ``` cargo set-version --bump minor -p tor-hsclient cargo set-version --bump minor -p arti-rpcserver cargo set-version --bump minor -p tor-hscrypto cargo set-version --bump minor -p tor-cell ``` 2023-06-29T21:14:00Z Nick Mathewson nickm@torproject.org 2023-06-29T21:14:00Z urn:sha1:a88fa71f25d888316f9b47b22a169525dbf7b2f2 Some of these seem spurious: it looks like fixup-features resolved an issue and then complained about it too. I'll investigate further. 2023-06-29T21:09:52Z Nick Mathewson nickm@torproject.org 2023-06-29T21:09:52Z urn:sha1:23c67d92e62f46629807c1c681267374b2dcd72e 2023-06-28T12:32:54Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-23T16:22:41Z urn:sha1:984652217a6d8b0c82c47a418531eb4112a4695c Invent a trait a la circmgr config for the hs client connector config. Plumb a suitable value all the way through to the code that will use it. 2023-06-26T13:30:54Z Nick Mathewson nickm@torproject.org 2023-06-26T13:30:54Z urn:sha1:0bffdf23a4c9f185b88eb426681bf9ca5f12610f The breaking changes here do not seem to affect us. 2023-06-23T16:49:46Z Nick Mathewson nickm@torproject.org 2023-06-22T19:43:25Z urn:sha1:9e3e683e1b3ea39768ff2a41ad6b0b7172d37a80 The relevant ErrorKinds and macros are now stable.