mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.0 2022-05-27T14:18:52Z 2022-05-27T14:18:52Z Nick Mathewson nickm@torproject.org 2022-05-27T14:18:52Z urn:sha1:4326aa1de9875ea399c3a608c0320bbe4b214a42 This commit was made by reverting the previous commit, then re-running the script I used to generate it. In theory there should be no semantic changes: only changes due to improved formatting from cargo edit. 2022-05-27T13:01:20Z Nick Mathewson nickm@torproject.org 2022-05-27T13:01:20Z urn:sha1:b232365a75249d6f767127feb2a47286f9ece762 I followed the following procedure to make these changes: * I used maint/changed_crates to find out which crates had changed since 0.3.0. * I used grep and maint/list_crates to sort those crates in topological (dependency) order. * I looked through semver_status to find which crates were listed as having semver-relevant changes (new APIs and breaking changes). * I scanned through the git logs of the crates with no semver-relevant changes listed to confirm that, indeed, they had no changes. For those crates, I incremented their patch-level version _without_ changing the version that other crates depend on. * I scanned through the git logs of the crates with no semver-relevant changes listed to confirm that, indeed, they had no obvious breaking changes. * I treated all crates that depend on `arti` and/or `arti-client` as having breaking changes. * I identified crates that depend on crates that have changed, even if they have not changed themselves, and identified them as having a non-breaking change. * For all of the crates, I used `cargo set-version -p $CRATE --bump $STATUS` (where `STATUS` is `patch` or `minor`) to update the versions, and the depended-upon versions. 2022-05-24T19:09:00Z Nick Mathewson nickm@torproject.org 2022-05-24T19:09:00Z urn:sha1:460117f2b015435a2b34be102ead148f8ad0bd2c 2022-05-12T17:50:26Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T09:36:54Z urn:sha1:86a3e006d3de3832ad0254ca95a01e78e080e843 Test the Deserialize impl of every config struct. This detects bugs like the one fixed in !502. The macro now becomes more complex because it needs to take options. Right now this tt-munching option parser is overkill, but this leave space for further options in the future. 2022-05-12T14:59:13Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T14:58:58Z urn:sha1:c1c6f2b376827c4ebb13bc08456f8355717d15e5 I have Plans for this macro. In particular: * I have a wip branch which tests that the Builder can be deserialised from an empty config (ie, that config reading of a config with a blank section for this item works). * I think we should autogenerate $Config::builder(), and promote that, rather than $ConfigBuilder::default(). This macro could do that. 2022-05-11T17:27:15Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-11T16:32:41Z urn:sha1:7909a51ff4101dafbe2a0c2f5d4a7b6a7236eb51 2022-05-06T14:03:15Z Nick Mathewson nickm@torproject.org 2022-05-06T14:03:15Z urn:sha1:7b93091f57f43ec8543a17052d60a2c8f7f2b0cc * Except for safelog and fs-mistrust, which are new. 2022-05-06T13:51:11Z Nick Mathewson nickm@torproject.org 2022-05-06T13:51:11Z urn:sha1:9447e6935551a4d3824dede6016e1eac09b77b53 2022-05-06T12:36:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-06T12:18:03Z urn:sha1:030289481f79d7b1de4084e485b1793042b36ee8 For reference, the git source for this crate (and the others in its workspace) currently lives in my personal github account (ijackson). If this fork turns out to be long-lived and gains features and/or users, it would be good to move it to a gitlab somewhere. I have granted Nick crate ownership on the crates.io system. 2022-05-05T09:35:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T16:45:25Z urn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861 * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.)