mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.0 2022-05-06T14:03:15Z 2022-05-06T14:03:15Z Nick Mathewson nickm@torproject.org 2022-05-06T14:03:15Z urn:sha1:7b93091f57f43ec8543a17052d60a2c8f7f2b0cc * Except for safelog and fs-mistrust, which are new. 2022-05-06T13:51:11Z Nick Mathewson nickm@torproject.org 2022-05-06T13:51:11Z urn:sha1:9447e6935551a4d3824dede6016e1eac09b77b53 2022-05-06T12:36:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-06T12:18:03Z urn:sha1:030289481f79d7b1de4084e485b1793042b36ee8 For reference, the git source for this crate (and the others in its workspace) currently lives in my personal github account (ijackson). If this fork turns out to be long-lived and gains features and/or users, it would be good to move it to a gitlab somewhere. I have granted Nick crate ownership on the crates.io system. 2022-05-05T09:35:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T16:45:25Z urn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861 * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.) 2022-05-04T18:13:45Z Ian Jackson iwj@torproject.org 2022-05-04T18:13:45Z urn:sha1:a334f17262e80620cfffa3c2ec5f50d4ea49a22f FallbackDir: orports: Introduce and use VecBuilder See merge request tpo/core/arti!474 2022-05-04T16:18:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:20:08Z urn:sha1:4ad4cae4180981856676f675e32117b683518f4e And drop the ad-hoc orport() method. This brings FallbackDir's orports field in line with our list builder API. The general semver note in "configuation" seems to cover most of this. 2022-05-04T16:18:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:05:32Z urn:sha1:cc394ca9b9460878867e94fd43bd22bee88da37f This avoids it having to recapitulate defaulting logic. 2022-05-04T16:18:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T14:55:43Z urn:sha1:6791758d0bca8c13aa4d7a569470f606bfeb653e 2022-05-04T15:16:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:34:40Z urn:sha1:015db3d78d04969971d7254b1a839c5693cb2720 Although these do not appear in the config, it does have a builder. It seems sensible to get rid of this ad-hoc list manipulation site, and replace it with our standard list builder API. define_list_builder_helper requires that the builder element type be Deserialize. Currently GuardUsageRestriction is a transparent, public enum, so we aren't really exposing anything. We could introduce GuardUsageRestrictionBuilder now, but since it's not in the config and thereofore only in the public API of the lower crates, we can definitely put that off. 2022-05-04T12:50:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T12:32:35Z urn:sha1:4bca91271558d950092fb1ac51c1316655d293cb The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements).