mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.5.0 2022-06-24T13:23:38Z 2022-06-24T13:23:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-24T12:24:00Z urn:sha1:23c352b96bf07c981bb396fa34ce83e512ada0b2 Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead. 2022-06-23T18:15:42Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-23T18:15:29Z urn:sha1:589c6e52bb49ccfe6c0ad9d18d6b994978e46c6c Update all lint blocks 2022-06-17T13:16:16Z Nick Mathewson nickm@torproject.org 2022-06-17T13:16:16Z urn:sha1:9ae57e8bc477229935adae6b2e81846cee03cd17 Implement support for reachable_addrs Closes #491 and #93 See merge request tpo/core/arti!583 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-15T19:14:25Z urn:sha1:f4c9b9cc1e5c726c01d3c956ac1fa9f7bc7b98a7 Also, improve its documentation. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-15T19:07:25Z urn:sha1:03568cd4a5643be5314dd43b029596f276e99f41 Now the primary exposed function is `pick_guard` again. This commit is just function renaming. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-15T19:03:08Z urn:sha1:1be44891c9d9a7d30ade2178ecd04fad08cc8026 At the site of modify_hop, we now have a comment explaining the internal-error issue. To make the internal error less likely, we lower the modify_hop call in lib.rs into GuardSet, where it can make sure it's looking at the same filter as was used to select the guard. The function name "pick_guard_ext" is not permanent; I'm going to rename it in the next commit. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-10T14:07:45Z urn:sha1:96dfa97473450d6e4cbd93b0ffa8a11021096298 Previously, the API said "you need to call this in a loop till it returns false". We did that in one place, but not another. With the introduction of filters, forgetting to loop here becomes a bug: so instead, change the behavior of extend_sample_as_needed so it handles looping itself. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-10T13:55:28Z urn:sha1:a92dfa0b2aab07ba6cffd9d9be916f9096a6b33f These all say, in one form or another, "there is no guard filtering; there is only one selection". That's now false. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-10T13:37:45Z urn:sha1:89f9e1decb7872d688d126fe41ab28b6bd0504a0 The fake network we construct for these tests is small in ways that can sometimes cause weird behavior with guard filters. We fix this by adjusting the parameters of the guard selection algorithm accordingly in the tests. With these new parameters, #491 no longer occurs. This commit also adds comments to explain why the parameters are set as they are. Closes #491. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-01T17:50:38Z urn:sha1:48a86506be0e9bb1dc3cab0ba3c05a9fda6f1e46 guard-spec.txt specifies that we have multiple separate samples of guards that we can use depending on whether the filter is restrictive or not. Here we implement the rules for switching between samples.