mirrors/arti.git/crates/tor-guardmgr/src/vanguards/set.rs, branch arti-v1.3.1mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.12024-09-10T14:26:02Ztor-guardmgr: Convert a TODO into a NOTE.2024-09-10T14:26:02ZGabriela Moldovangabi@torproject.org2024-09-10T14:24:15Zurn:sha1:1d71d47171b886e66eb21422fff2dcd6840f0d92
This behavior is OK, so this doesn't need to be a TODO.
See the discussion at
https://gitlab.torproject.org/tpo/core/arti/-/issues/1352#note_3015217
Closes #1352
Fix typos2024-09-03T08:09:02ZDimitris Apostoloudimitris.apostolou@icloud.com2024-09-03T08:09:02Zurn:sha1:676f913463b7d84f34dd6101b99d03ef79cf57adtor-guardmgr: Return a BootstrapRequired error if all the sets are empty.2024-05-09T16:37:39ZGabriela Moldovangabi@torproject.org2024-05-09T10:50:41Zurn:sha1:ed4c57dbfb538fa5f270b6ca83b651c5ae8c8700
Previously, `select_vanguard` returned a `NoSuitableRelay` error if
it was unable to select a relay to use as a vanguard.
We now distunguish the "there are no suitable relays in the vanguard
sets" (`NoSuitableRelays`) error case from the "our vanguard sets are
empty" (`BootstrapRequired`) one.
tor-guardmgr: Remove TODO about removing Vanguard abstraction.2024-05-09T16:37:39ZGabriela Moldovangabi@torproject.org2024-05-09T10:11:58Zurn:sha1:1da0bac05f857508507aa722806fe19af79c32fe
I think it's alright to keep it: it gives us the flexibility to extend
it later on, if needed.
tor-guardmgr: Remove a TODO HS-VANGUARDS.2024-05-09T16:37:39ZGabriela Moldovangabi@torproject.org2024-05-09T10:03:20Zurn:sha1:c73b2791e67290cf9f6889fdd5f4a96f5a121446
This TODO doesn't really need to be implemented: we can test the
`VanguardMgr` just the same without it (`GuardMgrInner` is similar, in
that it doesn't mock the rng).
tor-guardmgr: Make remove_unlisted return the number of unlisted vanguards.2024-04-30T09:37:45ZGabriela Moldovangabi@torproject.org2024-04-30T09:37:45Zurn:sha1:866aab7a9d567a7e9af101332c85d600b640a552
For symmetry with remove_expired.
tor-guardmgr: Make remove_expired return the number of expired vanguards.2024-04-30T09:37:36ZGabriela Moldovangabi@torproject.org2024-04-30T09:36:14Zurn:sha1:43039566744ba69dac903b3d9f081d112eb30395
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2109#note_3024672
tor-guardmgr: Prevent misleading logs when not rotating vanguards.2024-04-29T18:07:56ZGabriela Moldovangabi@torproject.org2024-04-29T18:02:55Zurn:sha1:3450d19bb670fd274559e03c340745e5aafc6775
`rotate_expired()` now only logs that it is rotating the vanguards if
some existing vanguards have actually expired.
tor-guardmgr: Remove unnecessary clippy allows.2024-04-29T13:10:37ZGabriela Moldovangabi@torproject.org2024-04-23T17:52:39Zurn:sha1:04f4b4290aabbea6a7c9cf7be1e8f9b445a4b11a
None of these should be unused anymore.
tor-guardmgr: Remove unnecessary VanguardSetsTrackedMut contraption.2024-04-22T16:23:17ZGabriela Moldovangabi@torproject.org2024-04-22T15:52:32Zurn:sha1:3502a6270c7d50424bc5772834e24b299fb36049
The VanguardMgr now unconditionally flushes the vanguard sets to disk
each time there's a consensus change, and every time a vanguard
expires.
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2090#note_3021013