mirrors/arti.git/crates/tor-guardmgr/src/util.rs, branch arti-v2.5.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.0 2026-06-09T15:36:01Z maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. tor-guardmgr: Port to web_time_compat. 2026-03-26T19:20:17Z Nick Mathewson nickm@torproject.org 2026-03-26T15:06:10Z urn:sha1:02421eae87ee34653960046c25b6239b01f557c9 Fix name of clippy lint to unchecked_time_subtraction (2) 2025-11-06T11:28:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-06T11:23:25Z urn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff Run maint/add_warning Run maint/add_warning. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Merge branch 'clippy-allow' into 'main' 2023-07-11T09:37:42Z Ian Jackson iwj@torproject.org 2023-07-11T09:37:42Z urn:sha1:3acc2af4f3411588f80669ae1980679dd260b119 clippy: Allow some of our existing code patterns See merge request tpo/core/arti!1396 rng ranges: Use gen_range_infallible() for Duration::ZERO..=T 2023-07-10T15:08:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-07T13:19:55Z urn:sha1:b151237a7f8651ed8694748832af05786a7eccfd Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 rng ranges: Use inclusive Duration ranges in several places 2023-07-07T15:13:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-07T13:10:23Z urn:sha1:bcc3e6fef8b863fa6a863aae2d6234fba7fb99f6 Many of these call sites would panic if, somehow, the upper bound was zero. In most cases it is very complicated to see if whether this could happen. However, there is a better answer: Durations are (conceptually) dense, so picking the closed set (which includes its boundary) rather than the open one (which doesn't) will make little practical difference. So change four call sites to use `..=` instead of just `..`. Use humantime in tor-guardmgr 2023-02-27T15:54:29Z Saksham Mittal gotlouemail@gmail.com 2023-02-27T15:54:29Z urn:sha1:dfb94f510d1c34468d91b242a6b21a17f90839f5