mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-dirmgr-v0.5.1 2022-07-07T17:16:06Z 2022-07-07T17:16:06Z Nick Mathewson nickm@torproject.org 2022-07-07T17:03:38Z urn:sha1:287fe915f9b0eb1fdc753b396e3f8bdc907a8e39 This uses similar techniques to the commit I just did for Fallbacks. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-15T19:07:25Z urn:sha1:03568cd4a5643be5314dd43b029596f276e99f41 Now the primary exposed function is `pick_guard` again. This commit is just function renaming. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-15T19:03:08Z urn:sha1:1be44891c9d9a7d30ade2178ecd04fad08cc8026 At the site of modify_hop, we now have a comment explaining the internal-error issue. To make the internal error less likely, we lower the modify_hop call in lib.rs into GuardSet, where it can make sure it's looking at the same filter as was used to select the guard. The function name "pick_guard_ext" is not permanent; I'm going to rename it in the next commit. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-10T14:07:45Z urn:sha1:96dfa97473450d6e4cbd93b0ffa8a11021096298 Previously, the API said "you need to call this in a loop till it returns false". We did that in one place, but not another. With the introduction of filters, forgetting to loop here becomes a bug: so instead, change the behavior of extend_sample_as_needed so it handles looping itself. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-10T13:55:28Z urn:sha1:a92dfa0b2aab07ba6cffd9d9be916f9096a6b33f These all say, in one form or another, "there is no guard filtering; there is only one selection". That's now false. 2022-06-17T12:46:16Z Nick Mathewson nickm@torproject.org 2022-06-01T14:49:57Z urn:sha1:a189aaf1fb1ae7b1f62094a475771c9357d2e6fb Since a guard can have a bunch of addresses, and the guard is permitted if any one of those addresses is permitted, then we might decide to use a guard with some non-permitted addresses. Thus, we need to filter those addresses before returning the view of the guard as a FirstHop. 2022-06-13T13:26:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-13T13:26:32Z urn:sha1:3e035927f20e88fa01f3b82649daa08551c4fda6 Run rustfmt. Separate commit to make review of the substantive commit easier. 2022-06-13T13:25:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-13T13:25:45Z urn:sha1:7d223ac9e6c6d998d51a2d66baaeddea086dca37 This is a *lot* of unwraps. The function takes no parameters and is used only for testing. It ought to be infallible. 2022-04-07T20:01:46Z Nick Mathewson nickm@torproject.org 2022-04-07T16:16:13Z urn:sha1:eedee51899eb3365a21c37be3803846373265284 (This is just a placeholder; I'm going to make the functions smarter in the next commit.) 2022-04-07T15:33:34Z Nick Mathewson nickm@torproject.org 2022-04-07T15:30:08Z urn:sha1:99146da2c2654c01259b8219bd491c5d4ac47039 (It is not yet actually used.)