mirrors/arti.git/crates/tor-guardmgr/src/sample.rs, branch ios-sqlite-hacks mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks 2023-08-23T09:34:00Z Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 "Fix" remaining unchecked-subtraction warnings. 2023-01-27T14:16:41Z Nick Mathewson nickm@torproject.org 2023-01-27T13:20:08Z urn:sha1:2127c6b0883cfeedb92c1c88ccff59d63acd22a5 In both cases I think it's fine to panic; but it's best to do so explicitly. Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks. Merge branch 'remove_deadcode_allow' into 'main' 2022-11-23T17:45:26Z Nick Mathewson nickm@torproject.org 2022-11-23T17:45:26Z urn:sha1:e25ed00fd108a2a7e029e1bb3ef70f8db2069aba guardmgr: Remove a now-unneeded "allow(dead_code)" See merge request tpo/core/arti!862 GuardMgr: split Reachable::Unknown into Untried and Retriable 2022-11-17T17:21:06Z Nick Mathewson nickm@torproject.org 2022-11-17T17:17:42Z urn:sha1:6c5dd0569873bc29671a3debdf8080febfa11c65 There are two cases here, and we will want to log them differently. (By removing the "Unknown" variant entirely, we ensure that we didn't miss any code that formerly checked for Unknown.) guardmgr: Remove a now-unneeded "allow(dead_code)" 2022-11-16T14:22:23Z Nick Mathewson nickm@torproject.org 2022-11-16T14:22:23Z urn:sha1:4a1b3d895411dcf08fdec934e4db6b1057fc4f4d GuardSet: Add a method to report which bridge descs we want. 2022-11-14T18:36:10Z Nick Mathewson nickm@torproject.org 2022-11-09T12:39:03Z urn:sha1:0f4c7a477ac8e0d4a781d3be27250fc583404232 GuardMgr: remove redundant call to extend_sample_as_needed 2022-11-10T17:11:28Z Nick Mathewson nickm@torproject.org 2022-11-08T17:28:19Z urn:sha1:11e83d8069c074cc899594528c277266595464e8 Previously we would call extend_sample_as_needed in only two places, one of which called the other unconditionally. That's obviously not necessary. I've selected just one of them (`update_guardset_internal`) since it fits better with the theme if that function. I've added comments explaining what is going on. This commit also introduces a yes/no enum for "were any guards added while extending this set". Formerly we had a boolean, but it got passed around so many times that I think its intent became obscure.