mirrors/arti.git/crates/tor-guardmgr/src/sample.rs, branch arti-v1.1.3mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.32023-01-27T14:16:41Z"Fix" remaining unchecked-subtraction warnings.2023-01-27T14:16:41ZNick Mathewsonnickm@torproject.org2023-01-27T13:20:08Zurn:sha1:2127c6b0883cfeedb92c1c88ccff59d63acd22a5
In both cases I think it's fine to panic; but it's best to do so
explicitly.
Allow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.
test lint blocks: Add many many automatically2022-12-12T18:00:30ZIan Jacksonijackson@chiark.greenend.org.uk2022-12-12T17:58:40Zurn:sha1:125a455bdcca841931f33f83f206e57637ae85c4
This is precisely the result of running the rune in
maint/adhoc-add-lint-blocks.
Merge branch 'remove_deadcode_allow' into 'main'2022-11-23T17:45:26ZNick Mathewsonnickm@torproject.org2022-11-23T17:45:26Zurn:sha1:e25ed00fd108a2a7e029e1bb3ef70f8db2069aba
guardmgr: Remove a now-unneeded "allow(dead_code)"
See merge request tpo/core/arti!862GuardMgr: split Reachable::Unknown into Untried and Retriable2022-11-17T17:21:06ZNick Mathewsonnickm@torproject.org2022-11-17T17:17:42Zurn:sha1:6c5dd0569873bc29671a3debdf8080febfa11c65
There are two cases here, and we will want to log them
differently.
(By removing the "Unknown" variant entirely, we ensure that we
didn't miss any code that formerly checked for Unknown.)
guardmgr: Remove a now-unneeded "allow(dead_code)"2022-11-16T14:22:23ZNick Mathewsonnickm@torproject.org2022-11-16T14:22:23Zurn:sha1:4a1b3d895411dcf08fdec934e4db6b1057fc4f4dGuardSet: Add a method to report which bridge descs we want.2022-11-14T18:36:10ZNick Mathewsonnickm@torproject.org2022-11-09T12:39:03Zurn:sha1:0f4c7a477ac8e0d4a781d3be27250fc583404232GuardMgr: remove redundant call to extend_sample_as_needed2022-11-10T17:11:28ZNick Mathewsonnickm@torproject.org2022-11-08T17:28:19Zurn:sha1:11e83d8069c074cc899594528c277266595464e8
Previously we would call extend_sample_as_needed in only two places,
one of which called the other unconditionally. That's obviously not
necessary.
I've selected just one of them (`update_guardset_internal`) since it
fits better with the theme if that function. I've added comments
explaining what is going on.
This commit also introduces a yes/no enum for "were any guards added
while extending this set". Formerly we had a boolean, but it got
passed around so many times that I think its intent became obscure.
GuardMgr: rename n_primary_without_dir_info2022-11-10T17:11:28ZNick Mathewsonnickm@torproject.org2022-11-08T17:09:55Zurn:sha1:1d4db04e4e5c620dae2305dd5b1cb022a24a6ac2
What this function actually does is return the number of primary
guards whose presence (by identity) is ambiguous in a current
universe. The new name and documentation should help avoid
confusion.
The method's old name had led me astray when identifying whether it
should apply to bridges in one case. This commit also removes the
corresponding `TODO pt-client`.
GuardMgr: Fix build with bridge-client disabled.2022-11-08T13:10:15ZNick Mathewsonnickm@torproject.org2022-11-04T20:10:42Zurn:sha1:9fda8d17c4b65d0af9c6aee00bf10ebc68c907dd