mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.0 2022-11-23T17:45:26Z 2022-11-23T17:45:26Z Nick Mathewson nickm@torproject.org 2022-11-23T17:45:26Z urn:sha1:e25ed00fd108a2a7e029e1bb3ef70f8db2069aba guardmgr: Remove a now-unneeded "allow(dead_code)" See merge request tpo/core/arti!862 2022-11-17T17:21:06Z Nick Mathewson nickm@torproject.org 2022-11-17T17:17:42Z urn:sha1:6c5dd0569873bc29671a3debdf8080febfa11c65 There are two cases here, and we will want to log them differently. (By removing the "Unknown" variant entirely, we ensure that we didn't miss any code that formerly checked for Unknown.) 2022-11-16T14:22:23Z Nick Mathewson nickm@torproject.org 2022-11-16T14:22:23Z urn:sha1:4a1b3d895411dcf08fdec934e4db6b1057fc4f4d 2022-11-14T18:36:10Z Nick Mathewson nickm@torproject.org 2022-11-09T12:39:03Z urn:sha1:0f4c7a477ac8e0d4a781d3be27250fc583404232 2022-11-10T17:11:28Z Nick Mathewson nickm@torproject.org 2022-11-08T17:28:19Z urn:sha1:11e83d8069c074cc899594528c277266595464e8 Previously we would call extend_sample_as_needed in only two places, one of which called the other unconditionally. That's obviously not necessary. I've selected just one of them (`update_guardset_internal`) since it fits better with the theme if that function. I've added comments explaining what is going on. This commit also introduces a yes/no enum for "were any guards added while extending this set". Formerly we had a boolean, but it got passed around so many times that I think its intent became obscure. 2022-11-10T17:11:28Z Nick Mathewson nickm@torproject.org 2022-11-08T17:09:55Z urn:sha1:1d4db04e4e5c620dae2305dd5b1cb022a24a6ac2 What this function actually does is return the number of primary guards whose presence (by identity) is ambiguous in a current universe. The new name and documentation should help avoid confusion. The method's old name had led me astray when identifying whether it should apply to bridges in one case. This commit also removes the corresponding `TODO pt-client`. 2022-11-08T13:10:15Z Nick Mathewson nickm@torproject.org 2022-11-04T20:10:42Z urn:sha1:9fda8d17c4b65d0af9c6aee00bf10ebc68c907dd 2022-11-08T13:10:15Z Nick Mathewson nickm@torproject.org 2022-11-04T19:47:08Z urn:sha1:6bcce1965592f3886abbccd55828a79b419c23ec Also remove a bunch of now-unnecessary `allow(dead_code)` annotations. 2022-11-08T13:10:15Z Nick Mathewson nickm@torproject.org 2022-11-04T13:45:15Z urn:sha1:697a355a21968d40c431db5072943fd9a6dc7999 This can probably be done in a simpler way, but for the moment I would prefer to try to minimize the amount of code I'm changing here. 2022-11-03T15:44:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-03T15:44:32Z urn:sha1:aa375e2e0947535ff257c63af893bc386c1a3bcc Without this, an unused import warning is generated when building without features.