mirrors/arti.git/crates/tor-guardmgr/src/sample.rs, branch arti-v0.0.3

Tests for new guardmgr functionality.

2022-01-06T20:58:36Z

Add API to check if primary MDs are missing.

2022-01-06T20:58:23Z

We need this information to know if it's okay to migrate to a new NetDir, or if we need to download more information first. Part of #178.

Make TlsConnector wrap TCP connections, not create its own

2021-12-07T17:00:40Z

`tor-rtcompat`'s `TlsConnector` trait previously included a method to create a TLS-over-TCP connection, which implied creating a TCP stream inside that method. This commit changes that, and makes the function wrap a TCP stream, as returned from the runtime's `TcpProvider` trait implementation, instead. This means you can actually override `TcpProvider` and have it apply to *all* connections Arti makes, which is useful for issues like arti#235 and other cases where you want to have a custom TCP stream implementation. This required updating the mock TCP/TLS types in `tor-rtmock` slightly; due to the change in API, we now store whether a `LocalStream` should actually be a TLS stream inside the stream itself, and check this property on reads/writes in order to detect misuse. The fake TLS wrapper checks this property and removes it in order to "wrap" the stream, making reads and writes work again.

add semicolons if nothing returned

2021-11-25T13:20:37Z

deglob some enums, use concise iteration syntax

2021-11-25T12:39:52Z

tor-guardmgr: Add tests for a few functions.

2021-11-02T16:17:11Z

Mark primary guards as retriable when we come back online.

2021-11-02T16:17:11Z

We define "coming back online" as happening when a guard attempt succeeds, if that attempt that was launched when we seemed to be offline. We define "seeming to be offline" as having all of our primary guards marked unreachable, and having received no incoming network traffic in a while. Closes #216.

Add #[serde(flatten)] HashMap fields to serializable objects

2021-10-27T12:31:52Z

As per arti#175, we'd like to be able to handle newer Arti versions storing additional state in the persisted state files, without dropping this data on the floor when we write out changes to these files. Use the #[serde(flatten)] mechanism to achieve this, by adding catch-all HashMap fields to all structs that are at risk of this happening to them.

Avoid a strange borrow syntax in tor_guardmgr::sample

2021-10-26T16:03:23Z

I'm not sure what I was thinking here.

Implement a "lightweight" form of pathbias detection.

2021-10-26T16:03:23Z

We now track, for every guard: the total number of successful circuits we've built through it, along with the total number of "indeterminate" circuits. Recall that a circuit's status is "indeterminate" if it has failed for a reason that _might_ be the guard's fault, or might not be the guard's fault. For example, if extending to the second hop of the circuit fails, we have no way to know whether the guard deliberately refused to connect there, or whether the second hop is just offline. But we don't want to forgive all indeterminate circuit failures: if we did, then a malicious guard could simply reject any second hops that it didn't like, thereby filtering the client into a chosen set of circuits. As a stopgap solution, this patch now makes guards become permanently disabled if the fraction of their circuit failures becomes too high. See also general-purpose path bias selection (arti#65), and Mike's idea for changing the guard reachability definition (torspec#67). This patch doesn't do either of those. Closes #185.