mirrors/arti.git/crates/tor-guardmgr/src/lib.rs, branch arti-v0.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.2.02022-03-30T14:41:40ZFix some Rustdoc links.2022-03-30T14:41:40ZNick Mathewsonnickm@torproject.org2022-03-29T15:17:34Zurn:sha1:3e92d30e4999f0cd50afd3359c73abfdbaf61d8aRefactor FirstHopId into type-differentiated form2022-03-30T14:41:39ZNick Mathewsonnickm@torproject.org2022-03-29T14:55:20Zurn:sha1:6282df34fb00c3b8b686553e05f8d3172b017ed0
The FirstHopId type now records an enum that stores whether the hop
is a guard or a fallback. This change addresses concerns about
remembering to check the type or source of an Id before passing it
down to the FallbackState or GuardSet.
Making this change required an API change, so that dirmgr can
report success/failure status without actually knowing whether it's
using a fallback or a guard.
Rename Guard=>FirstHop, GuardId=>FirstHopId2022-03-30T14:40:59ZNick Mathewsonnickm@torproject.org2022-03-29T13:05:39Zurn:sha1:13af6134f6180f7241daca9206fa49ed5f26829d
This is preparation for having separate GuardId and FirstHopId types
that distinguish which back-end they index.
Rename FallbackSet => FallbackState.2022-03-30T14:40:14ZNick Mathewsonnickm@torproject.org2022-03-29T12:42:03Zurn:sha1:b1ccd3c7dc1902c52cd2f63a15c7c81e320fb171Refactor select_guard_with_expand to use match and log errors.2022-03-30T14:40:14ZNick Mathewsonnickm@torproject.org2022-03-29T12:32:06Zurn:sha1:2cf00e63de264c871e1f04eec220c8da2ccaf790Rename ExternalFailure => ExternalActivity.2022-03-30T14:40:12ZNick Mathewsonnickm@torproject.org2022-03-26T00:32:52Zurn:sha1:bdd129f23094b58b738c87d4655783004fac2274Replace the fallback directories when they change in the config.2022-03-30T14:39:09ZNick Mathewsonnickm@torproject.org2022-03-26T00:28:05Zurn:sha1:d88e9d676e8204078152fccc7f9ef893e136ac03
The code here uses a new iterator type, since I couldn't find one of
these on crates.io. I tried writing the code without it, but it was
harder to follow and test.
Add status tracking to FallbackDir.2022-03-30T14:39:09ZNick Mathewsonnickm@torproject.org2022-03-25T23:19:57Zurn:sha1:bfb2353a8f627b189e104e606b3284fdfaa6d98b
We do this by creating a new FallbackSet type that includes status
information, and updating the GuardMgr APIs to record success and
failure about it when appropriate. We can use this to mark
FallbackDirs retriable (or not).
With this change, FallbackDir is now stored internally as a Guard in
the GuardMgr crate. That's fine: the FallbackDir type really only
matters for configuration.
GuardMgr: Return fallback directories when appropriate.2022-03-30T14:39:09ZNick Mathewsonnickm@torproject.org2022-03-25T20:51:59Zurn:sha1:40c82324268d8d6ad333ec8625abd7e08649db9f
We only do this when we fail to get a regular guard (e.g., because
they're all down), and when we have been asked for a guard for a
one-hop directory.
Most of the change in this commit is plumbing to make all of the
types match up.
As before, compilation may still be broken.
Fix typos in guardmgr/lib.rs2022-03-30T14:39:09ZNick Mathewsonnickm@torproject.org2022-03-25T20:51:19Zurn:sha1:9e31ee0c9bc5fbac42049ca29e97a098ccb143c2