mirrors/arti.git/crates/tor-guardmgr/src/guard.rs, branch arti-v1.2.2 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.2 2024-03-13T16:30:53Z Run maint/add_warning. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c educe: Use std's default for enums where default variant is unit 2024-02-12T11:38:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-02-12T11:07:42Z urn:sha1:c35c60f848154e80f23ba95a989ff2f9d2594e6a Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible. Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Stop unconditionally marking bridges as having dir info. 2023-07-13T19:43:42Z Nick Mathewson nickm@torproject.org 2023-07-13T19:28:36Z urn:sha1:7a915f5454599ee0042fe243a82a78510501c76f When we implemented bridges, we added code in 08473872abccf389 to conditionally mark their directory info as present or not present. But the we didn't remove the old code to mark them present unconditionally! Fixes #638. Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 guardmgr, netdir: fix some needless-mut warnings 2023-05-18T16:54:55Z Nick Mathewson nickm@torproject.org 2023-05-18T16:54:55Z urn:sha1:41863bd62250d20634b65a6ff2d4ab6a492e8459 Found by clippy nightly tor-guardmgr, tor-proto: minor logging tweaks 2023-05-18T15:04:11Z eta tor@eta.st 2023-05-18T13:55:50Z urn:sha1:4665835ee8879bf4d11ccf56420b899909cf32ff - We make the tor-guardmgr "We have found that {} is usable" line include the word "guard", otherwise it doesn't appear very useful to a user in safe logging mode, since the guard gets replaced with [scrubbed]. - The "Actually got an end cell..." message is downgraded to DEBUG. Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks. guardmgr: Conditionalise DisplayRule::Redacted 2022-11-29T16:32:14Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-29T16:08:24Z urn:sha1:1bd606ab5ceb844c1c15820e8e11564d59a64e06 This is unused in bridgeless configs. Fixes a compiler warning.