mirrors/arti.git/crates/tor-guardmgr/src/guard.rs, branch arti-v1.1.5 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.5 2023-05-18T16:54:55Z guardmgr, netdir: fix some needless-mut warnings 2023-05-18T16:54:55Z Nick Mathewson nickm@torproject.org 2023-05-18T16:54:55Z urn:sha1:41863bd62250d20634b65a6ff2d4ab6a492e8459 Found by clippy nightly tor-guardmgr, tor-proto: minor logging tweaks 2023-05-18T15:04:11Z eta tor@eta.st 2023-05-18T13:55:50Z urn:sha1:4665835ee8879bf4d11ccf56420b899909cf32ff - We make the tor-guardmgr "We have found that {} is usable" line include the word "guard", otherwise it doesn't appear very useful to a user in safe logging mode, since the guard gets replaced with [scrubbed]. - The "Actually got an end cell..." message is downgraded to DEBUG. Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks. guardmgr: Conditionalise DisplayRule::Redacted 2022-11-29T16:32:14Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-29T16:08:24Z urn:sha1:1bd606ab5ceb844c1c15820e8e11564d59a64e06 This is unused in bridgeless configs. Fixes a compiler warning. Rustdoc fix: escape []s. 2022-11-28T14:36:15Z Nick Mathewson nickm@torproject.org 2022-11-28T14:36:15Z urn:sha1:5d6044f3fc4be51fe7d5973dd90f3a65a8ac0b52 GuardMgr: Treat Guards as sensitive and Bridges as redacted. 2022-11-28T13:01:53Z Nick Mathewson nickm@torproject.org 2022-11-23T18:19:43Z urn:sha1:cf9f29158f2958a7e8bfe19789289bec3de2dd8d This machinery is a bit inelegant, but it is all confined to be within the GuardMgr crate, so IMO it should be fine for now. Display guards in redacted form in guard status messages. 2022-11-28T13:01:53Z Nick Mathewson nickm@torproject.org 2022-11-21T19:39:38Z urn:sha1:29f903bdac93e0dfd712fcd83a192a0703ef6763 Closes #627, again. Closes #648. GuardMgr: Log when a guard status changes (significantly). 2022-11-17T17:32:57Z Nick Mathewson nickm@torproject.org 2022-11-17T17:32:57Z urn:sha1:8dfbbca4e58337878e030d183b8cba9c2e77d70a We previously had a trace message on _every_ change. That's fine, but we also want to log more important changes where the user can see them. Namely: * If we go from any other status to Reachable, we want to tell the user. (We don't want to spam them if it was already reachable.) * If we go from Untried or Reachable to Unreachable, we want to tell the user. (We don't tell them about changes from Retriable to Unreachable, since that just means that a retry attempt was not successful.) Closes #627. GuardMgr: split Reachable::Unknown into Untried and Retriable 2022-11-17T17:21:06Z Nick Mathewson nickm@torproject.org 2022-11-17T17:17:42Z urn:sha1:6c5dd0569873bc29671a3debdf8080febfa11c65 There are two cases here, and we will want to log them differently. (By removing the "Unknown" variant entirely, we ensure that we didn't miss any code that formerly checked for Unknown.)