mirrors/arti.git/crates/tor-guardmgr/src/guard.rs, branch arti-v1.1.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.42023-01-27T13:28:02ZAllow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.
test lint blocks: Add many many automatically2022-12-12T18:00:30ZIan Jacksonijackson@chiark.greenend.org.uk2022-12-12T17:58:40Zurn:sha1:125a455bdcca841931f33f83f206e57637ae85c4
This is precisely the result of running the rune in
maint/adhoc-add-lint-blocks.
guardmgr: Conditionalise DisplayRule::Redacted2022-11-29T16:32:14ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-29T16:08:24Zurn:sha1:1bd606ab5ceb844c1c15820e8e11564d59a64e06
This is unused in bridgeless configs. Fixes a compiler warning.
Rustdoc fix: escape []s.2022-11-28T14:36:15ZNick Mathewsonnickm@torproject.org2022-11-28T14:36:15Zurn:sha1:5d6044f3fc4be51fe7d5973dd90f3a65a8ac0b52GuardMgr: Treat Guards as sensitive and Bridges as redacted.2022-11-28T13:01:53ZNick Mathewsonnickm@torproject.org2022-11-23T18:19:43Zurn:sha1:cf9f29158f2958a7e8bfe19789289bec3de2dd8d
This machinery is a bit inelegant, but it is all confined to
be within the GuardMgr crate, so IMO it should be fine for now.
Display guards in redacted form in guard status messages.2022-11-28T13:01:53ZNick Mathewsonnickm@torproject.org2022-11-21T19:39:38Zurn:sha1:29f903bdac93e0dfd712fcd83a192a0703ef6763
Closes #627, again.
Closes #648.
GuardMgr: Log when a guard status changes (significantly).2022-11-17T17:32:57ZNick Mathewsonnickm@torproject.org2022-11-17T17:32:57Zurn:sha1:8dfbbca4e58337878e030d183b8cba9c2e77d70a
We previously had a trace message on _every_ change. That's fine,
but we also want to log more important changes where the user
can see them. Namely:
* If we go from any other status to Reachable, we want to tell
the user. (We don't want to spam them if it was already
reachable.)
* If we go from Untried or Reachable to Unreachable, we want to
tell the user. (We don't tell them about changes from Retriable
to Unreachable, since that just means that a retry attempt
was not successful.)
Closes #627.
GuardMgr: split Reachable::Unknown into Untried and Retriable2022-11-17T17:21:06ZNick Mathewsonnickm@torproject.org2022-11-17T17:17:42Zurn:sha1:6c5dd0569873bc29671a3debdf8080febfa11c65
There are two cases here, and we will want to log them
differently.
(By removing the "Unknown" variant entirely, we ensure that we
didn't miss any code that formerly checked for Unknown.)
GuardMgr: When possible, return a FirstHop that can be a CircTarget2022-11-08T13:10:15ZNick Mathewsonnickm@torproject.org2022-11-04T19:25:36Zurn:sha1:5c3bb3d7e1008c8fa95c693588f48c9d38010727
We do this by checking the FirstHops we're about to return, and when
they correspond to bridges, looking up an appropriate BridgeRelay
in the current BridgeSet (if we can).
GuardMgr: Fix and improve comments based on review.2022-11-02T12:07:32ZNick Mathewsonnickm@torproject.org2022-11-01T21:14:15Zurn:sha1:fc0c12510adce24d7c16e0b31ed79d65e75b366d