mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.0 2022-05-04T15:16:38Z 2022-05-04T15:16:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:34:40Z urn:sha1:015db3d78d04969971d7254b1a839c5693cb2720 Although these do not appear in the config, it does have a builder. It seems sensible to get rid of this ad-hoc list manipulation site, and replace it with our standard list builder API. define_list_builder_helper requires that the builder element type be Deserialize. Currently GuardUsageRestriction is a transparent, public enum, so we aren't really exposing anything. We could introduce GuardUsageRestrictionBuilder now, but since it's not in the config and thereofore only in the public API of the lower crates, we can definitely put that off. 2022-04-07T20:01:46Z Nick Mathewson nickm@torproject.org 2022-04-07T16:16:13Z urn:sha1:eedee51899eb3365a21c37be3803846373265284 (This is just a placeholder; I'm going to make the functions smarter in the next commit.) 2022-04-07T15:33:34Z Nick Mathewson nickm@torproject.org 2022-04-07T15:30:08Z urn:sha1:99146da2c2654c01259b8219bd491c5d4ac47039 (It is not yet actually used.) 2022-04-05T14:36:29Z Nick Mathewson nickm@torproject.org 2022-04-05T14:36:29Z urn:sha1:fe43f0ddb5463e5f1a9c780924d1002de3958045 2022-04-05T13:37:44Z Nick Mathewson nickm@torproject.org 2022-04-05T13:37:44Z urn:sha1:3ba9b47000103ac9ab3f2d5d8f75e51059b70f01 The old version of this function was error-prone, and in fact had errors: it was too easy to forget to add non-persistent fields, and that's exactly what we forgot in a few cases (`microdescriptor_missing`, `circ_history`, and `suspicious_behavior_warned`). The new version of this function consumes both of the incoming Guards, and constructs every field explicitly so that we can't forget to list any. Closes #429. 2022-04-05T13:18:04Z Nick Mathewson nickm@torproject.org 2022-04-04T19:41:28Z urn:sha1:b3e06b93b6a34922cd8d07f13aa8f265ae7e8af3 Previously, we treated successfully building a circuit to a guard as a "success", and any failure, including a directory cache failure, as a failure. With this change, guards now have separate success/failure and retry status for circuit usage and directory usage. This change is needed for guard-as-directory retry to have reasonable behavior. Otherwise, when a guard succeeds at building a circuit, that clears the directory-is-failing status and makes us retry the guards to quickly. 2022-03-30T14:41:40Z Nick Mathewson nickm@torproject.org 2022-03-29T15:17:34Z urn:sha1:3e92d30e4999f0cd50afd3359c73abfdbaf61d8a 2022-03-30T14:41:39Z Nick Mathewson nickm@torproject.org 2022-03-29T14:55:20Z urn:sha1:6282df34fb00c3b8b686553e05f8d3172b017ed0 The FirstHopId type now records an enum that stores whether the hop is a guard or a fallback. This change addresses concerns about remembering to check the type or source of an Id before passing it down to the FallbackState or GuardSet. Making this change required an API change, so that dirmgr can report success/failure status without actually knowing whether it's using a fallback or a guard. 2022-03-30T14:40:59Z Nick Mathewson nickm@torproject.org 2022-03-29T13:05:39Z urn:sha1:13af6134f6180f7241daca9206fa49ed5f26829d This is preparation for having separate GuardId and FirstHopId types that distinguish which back-end they index. 2022-03-30T12:55:58Z Nick Mathewson nickm@torproject.org 2022-03-30T12:55:58Z urn:sha1:700e491813f84d76446193aef7121a329b774717