mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-dirmgr-v0.5.1 2022-07-07T17:16:06Z 2022-07-07T17:16:06Z Nick Mathewson nickm@torproject.org 2022-07-06T18:06:45Z urn:sha1:d7a626aaa869f38938e33536fe0f0bc5d57042c0 Also re-order the filters to be a little more logical. 2022-06-24T13:23:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-24T12:24:00Z urn:sha1:23c352b96bf07c981bb396fa34ce83e512ada0b2 Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead. 2022-06-17T12:46:16Z Nick Mathewson nickm@torproject.org 2022-06-01T15:08:42Z urn:sha1:e3c2a86195f51d0b3cd28d4a01fb640289597a7d 2022-06-02T18:59:55Z Nick Mathewson nickm@torproject.org 2022-06-02T17:41:00Z urn:sha1:b4c0febd978444816d28e1aafb0248841a3c32b9 The trouble was that one of the helper functions they used did not take a PRNG as an argument. 2022-06-02T18:56:42Z Nick Mathewson nickm@torproject.org 2022-06-02T17:31:43Z urn:sha1:967ea67b7dfc158f29cf449eb09bac89acdee46b This only affects uses of thread_rng(), and affects them all more or less indiscriminately. One test does not work with ARTI_TEST_PRNG=deterministic; the next commit will fix it. 2022-05-05T09:35:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T16:45:25Z urn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861 * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.) 2022-05-04T16:18:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:20:08Z urn:sha1:4ad4cae4180981856676f675e32117b683518f4e And drop the ad-hoc orport() method. This brings FallbackDir's orports field in line with our list builder API. The general semver note in "configuation" seems to cover most of this. 2022-05-04T12:50:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T12:32:35Z urn:sha1:4bca91271558d950092fb1ac51c1316655d293cb The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements). 2022-04-25T17:23:02Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-25T17:00:56Z urn:sha1:83b9fbea9913e5ca4566332d412f1f91515e1d2b I don't think we need to bother with things in the prelude, but doing it for serde and ConfigBuildError seems nice. Noticed while writing a test case. 2022-04-25T17:22:54Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-25T16:38:40Z urn:sha1:ce877e442124cb61a38ffe4ab7b3f29ff1b3541f And add an imprecation in define_list_config_builder's doc comment do do so in future for other invocations of the macro. Add add the missing full stops.