mirrors/arti.git/crates/tor-guardmgr/src/fallback/set.rs, branch arti-v0.3.0

config derive attrs: Make builders serde, and validated structs not

2022-05-05T09:35:52Z

* Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.)

FallbackDir: Use VecBuilder for orports

2022-05-04T16:18:55Z

And drop the ad-hoc orport() method. This brings FallbackDir's orports field in line with our list builder API. The general semver note in "configuation" seems to cover most of this.

Change builder list API

2022-05-04T12:50:10Z

The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements).

list_builder: Use $crate namespaced imports

2022-04-25T17:23:02Z

I don't think we need to bother with things in the prelude, but doing it for serde and ConfigBuildError seems nice. Noticed while writing a test case.

Document defaults for all the config lists

2022-04-25T17:22:54Z

And add an imprecation in define_list_config_builder's doc comment do do so in future for other invocations of the macro. Add add the missing full stops.

Use better syntax for doc comment attribute

2022-04-25T16:05:30Z

As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/471#note_2798020

Introduce define_list_config_builder macro

2022-04-25T11:41:00Z

This replaces two almost-identical sets of structs and impls. More are on the way, as per https://gitlab.torproject.org/tpo/core/arti/-/issues/447

fallback list: Introduce and use FallbackListBuilder

2022-04-22T16:48:03Z

Now the network fallbacks configuration wants to Deserialize a Vec, rather than validated Vec. Methods on FallbackListBuilder are as per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/462#note_2797697 mutatis mutandi for the fact that this struct has only fallbacks in it.

Fold FallbackStatus into Entry.

2022-04-11T16:34:16Z

This simplifies the code a lot.

Initial functions to determine and expose a clock skew estimate.

2022-04-07T20:01:46Z

(This is just a placeholder; I'm going to make the functions smarter in the next commit.)