mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.2.0 2022-03-30T14:41:40Z 2022-03-30T14:41:40Z Nick Mathewson nickm@torproject.org 2022-03-29T15:17:34Z urn:sha1:3e92d30e4999f0cd50afd3359c73abfdbaf61d8a 2022-03-30T14:41:39Z Nick Mathewson nickm@torproject.org 2022-03-29T14:55:20Z urn:sha1:6282df34fb00c3b8b686553e05f8d3172b017ed0 The FirstHopId type now records an enum that stores whether the hop is a guard or a fallback. This change addresses concerns about remembering to check the type or source of an Id before passing it down to the FallbackState or GuardSet. Making this change required an API change, so that dirmgr can report success/failure status without actually knowing whether it's using a fallback or a guard. 2022-03-30T14:40:59Z Nick Mathewson nickm@torproject.org 2022-03-29T13:05:39Z urn:sha1:13af6134f6180f7241daca9206fa49ed5f26829d This is preparation for having separate GuardId and FirstHopId types that distinguish which back-end they index. 2022-03-30T14:40:14Z Nick Mathewson nickm@torproject.org 2022-03-29T12:42:03Z urn:sha1:b1ccd3c7dc1902c52cd2f63a15c7c81e320fb171 2022-03-30T14:40:14Z Ian Jackson iwj@torproject.org 2022-03-29T12:10:20Z urn:sha1:82ea251f3c22bd20a3b8f4d542606aef61d1af0d 2022-03-30T14:39:09Z Nick Mathewson nickm@torproject.org 2022-03-25T23:19:57Z urn:sha1:bfb2353a8f627b189e104e606b3284fdfaa6d98b We do this by creating a new FallbackSet type that includes status information, and updating the GuardMgr APIs to record success and failure about it when appropriate. We can use this to mark FallbackDirs retriable (or not). With this change, FallbackDir is now stored internally as a Guard in the GuardMgr crate. That's fine: the FallbackDir type really only matters for configuration. 2022-03-30T14:39:09Z Nick Mathewson nickm@torproject.org 2022-03-25T20:49:35Z urn:sha1:a4a5f2163d7d79d152498f0a59345a22ec1d55ca We need to extend our notion of "the origin of a guard" to include "somewhere outside the guard list"; we need the ability to return a FallbackDir as a Guard; and we need to remember a few more pieces of information in each pending request. As before, this commit may break compilation; it will be restored soon. 2022-03-30T14:39:06Z Nick Mathewson nickm@torproject.org 2022-03-25T20:44:12Z urn:sha1:9da43189f36b19681d10b78ef982c52c929b4573 The guard manager is responsible for handing out the first hops of tor circuits, keeping track of their successes and failures, and remembering their states. Given that, it makes sense to store this information here. It is not yet used; I'll be fixing that in upcoming commits. Arguably, this information no longer belongs in the directory manager: I've added a todo about moving it. This commit will break compilation on its own in a couple of places; subsequent commits will fix it up. 2022-03-30T14:34:48Z Nick Mathewson nickm@torproject.org 2022-03-25T17:38:01Z urn:sha1:80b65c3a4d4108c6b4b0cb91722f89c8e5859b7d This is the logical place for it, I think: the GuardMgr's job is to pick the first hop for a circuit depending on remembered status for possible first hops. Making this change will let us streamline the code that interacts with these objects.