mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.0 2022-11-24T17:17:36Z 2022-11-24T17:17:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-23T17:04:38Z urn:sha1:1a39a0c7e90204d6352fcc59811a355ae22aa43a Enums with variants conditional on cargo features must be non-exhaustive, because cargo features are supposed to be additive, meaning that enabling a feature (which might happen due to some random distant thing) ought not to break things using that enum. There were surprisingly few places to fix this. 2022-11-21T16:46:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-18T17:50:05Z urn:sha1:939d11c034e8358bb7ada6f5feb27a03c7b4b975 This type now does all the things people expect of it: you can (try to) deserialize it, parse it from a string, and call build on it. 2022-11-21T16:46:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-18T17:41:58Z urn:sha1:c4a3b0b5c4a9e31714b03aacf7bac330a485f32c This leaves this enum empty of actual errors, when bridge-client is disabled. We're going to add the not supported variant in a moment. 2022-11-21T16:46:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-18T17:41:04Z urn:sha1:5800b1cdc93ee0430a14682fb316663e1b271677 The dummy module is going to need an error type just like this but with only the disabled variant. To avoid that dummy enum getting out of step with the nontrivial one, we're going to make them the same. So as a first step, break this out into its own file.