mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.0 2022-05-27T14:18:52Z 2022-05-27T14:18:52Z Nick Mathewson nickm@torproject.org 2022-05-27T14:18:52Z urn:sha1:4326aa1de9875ea399c3a608c0320bbe4b214a42 This commit was made by reverting the previous commit, then re-running the script I used to generate it. In theory there should be no semantic changes: only changes due to improved formatting from cargo edit. 2022-05-27T13:01:20Z Nick Mathewson nickm@torproject.org 2022-05-27T13:01:20Z urn:sha1:b232365a75249d6f767127feb2a47286f9ece762 I followed the following procedure to make these changes: * I used maint/changed_crates to find out which crates had changed since 0.3.0. * I used grep and maint/list_crates to sort those crates in topological (dependency) order. * I looked through semver_status to find which crates were listed as having semver-relevant changes (new APIs and breaking changes). * I scanned through the git logs of the crates with no semver-relevant changes listed to confirm that, indeed, they had no changes. For those crates, I incremented their patch-level version _without_ changing the version that other crates depend on. * I scanned through the git logs of the crates with no semver-relevant changes listed to confirm that, indeed, they had no obvious breaking changes. * I treated all crates that depend on `arti` and/or `arti-client` as having breaking changes. * I identified crates that depend on crates that have changed, even if they have not changed themselves, and identified them as having a non-breaking change. * For all of the crates, I used `cargo set-version -p $CRATE --bump $STATUS` (where `STATUS` is `patch` or `minor`) to update the versions, and the depended-upon versions. 2022-05-06T14:03:15Z Nick Mathewson nickm@torproject.org 2022-05-06T14:03:15Z urn:sha1:7b93091f57f43ec8543a17052d60a2c8f7f2b0cc * Except for safelog and fs-mistrust, which are new. 2022-05-06T12:36:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-06T12:18:03Z urn:sha1:030289481f79d7b1de4084e485b1793042b36ee8 For reference, the git source for this crate (and the others in its workspace) currently lives in my personal github account (ijackson). If this fork turns out to be long-lived and gains features and/or users, it would be good to move it to a gitlab somewhere. I have granted Nick crate ownership on the crates.io system. 2022-04-27T14:31:08Z eta tor@eta.st 2022-04-27T14:31:08Z urn:sha1:6f787e1e7707c2125a5d0df457e7894f944f4aa6 derive_builder: Use git dep everywhere, rather than cargo patch See merge request tpo/core/arti!477 2022-04-27T13:57:59Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-27T13:44:59Z urn:sha1:a97ad69855cdf1931e29cc024a79336448f50990 The `[patch]` approach causes the tree not to build when used as a dependency, unless the `[patch]` is replicated into the depending project. Instead, replace our `derive_builer =` dependencies with a reference to a specific git commit: perl -i~ -pe 'next unless m/^derive_builder/; s#"(0\.11\.2)"#{ version = "$1", git = "https://github.com/ijackson/rust-derive-builder", rev = "ba0c1a5311bd9f93ddf5f5b8ec2a5f6f03b22fbe" }#' crates/*/Cargo.toml Note that the commitid has changed. This is because derive_builder is in fact a workspace of 4 crates. 3 of them are of interest to arti itself (the 4th exists only for testing). So the same "add git revision" treatment had to be done to the `derive_builder` and `derive_builder_macro` crates. Each dependency edge involves a new commit in the derive_builder workspace, since we can't create a git commit containing its own commitid. (We want to use commits, rather than a branch, so that what we are depending on is actually properly defined, and not subject to the whims of my personal github namespace.) There are no actual code changes in derive_builder. 2022-04-26T16:16:22Z Nick Mathewson nickm@torproject.org 2022-04-25T20:06:31Z urn:sha1:5586f0d039fc7b1fdec0e08579d5ecde3dcaa0a0 2022-04-25T17:05:31Z Nick Mathewson nickm@torproject.org 2022-04-25T16:19:02Z urn:sha1:b60b0a266a145d36950df638c83f8c4d55b6ae0b This is an automated change made with a perl one-liner and verified with grep -L and grep -l. Some warnings are introduced with this change; they will be removed in subsequent commits. See arti#208 for older discussion on this issue. 2022-04-25T17:04:31Z Nick Mathewson nickm@torproject.org 2022-04-25T16:10:41Z urn:sha1:ca05b0904c2fbb0c866127a78728cab7be28d61f This change was made automatically with a perl one-liner, and confirmed with `grep -L`. The `rust-version` field itself was introduced in 1.56.0. 2022-04-22T16:39:58Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-21T17:04:25Z urn:sha1:61425a96bd2d704a513bc8ed4bc20bb2e00a681c This is where the FallbackList type is. We are going to want to provide a builder too, which ought to impl Default. This means that the default value for the type must be next to the type. In any case, it was anomalous that it wasn't. This commit is pure code motion.