mirrors/arti.git/crates/tor-error/src, branch ios-sqlite-hacksmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks2023-08-23T09:34:00ZRun maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9actor-error: Remove KeystoreFsPermissions variant.2023-08-08T15:46:20ZGabriela Moldovangabi@torproject.org2023-08-08T15:40:28Zurn:sha1:5d0fb5177f50f87132cbc7d0a95c6f63d4de51d7
According to the `ErrorKind` lumping guidelines, `KeystoreFsPermissions`
should be lumped with `FsPermissions`: they represent the same type
of error, and their "location" is the same ("Host").
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1315#note_2916455
Run add_warnings on all files.2023-08-04T11:45:04ZNick Mathewsonnickm@torproject.org2023-08-04T11:45:04Zurn:sha1:cec6d0ce33b4b5cebbce57f55faec83397e9c953retry-error: Provide fmt_error_with_sources in retry-error2023-07-19T13:16:13ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-18T10:09:54Zurn:sha1:882ce8c8ce74d393b6d95dcede6e69a1a2e86c9b
This code came from tor-error. So now tor-error depends on
retry-error.
clippy: tor-error: Use convert::identity for into_internal!2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T12:38:24Zurn:sha1:fd2e4979be7007f79a0c2c47ac8b89db8ee534cb
This launders the closure so that clippy's
clippy::redundant_closure_call can't see it.
We can't have a local #[allow] because it would be on an expression,
which isn't allowed on stable.
This avoids having to use more clumsy idioms at call sites.
Run maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0Fix warn_report and error_report macros.2023-07-07T19:46:41ZNick Mathewsonnickm@torproject.org2023-07-07T19:46:41Zurn:sha1:53c599d50f6394a301f0aa491454bd69ba42a962
Originally they didn't check err.kind(), since err.kind() can never
increase their severity. We lost that behavior with !1386, and we
became dependent on it with arti!1383. Since they both merged at
the same time, CI broke.
This patch restores their original behavior.
tor-error: tracing module: Use macro to generate macros2023-07-07T17:38:24ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-07T16:43:26Zurn:sha1:696adc3c9407019a7969eeff9680d8ed668a730b
This abolishes some quintuplication.
The output is identical except that:
* The syntax display in the rustdoc output for the resulting macros
seems to have somewhat less whitepsace.
* The whimsical error messages in the examples are all identical.
Ah well.
tor-error: tracing module: Fix link to tracing macro2023-07-07T16:48:05ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-07T16:47:50Zurn:sha1:220900a852308042c237317eaca411782f0d0bd6Merge branch 'report-bugs-v2' into 'main'2023-07-07T13:49:59ZNick Mathewsonnickm@torproject.org2023-07-07T13:49:59Zurn:sha1:70f0fe634fedb359028e465d95083e23d3b3821b
Optional tracing support in tor-error for error reporting
See merge request tpo/core/arti!1379