mirrors/arti.git/crates/tor-error/src, branch arti-v1.2.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.0 2024-01-31T14:26:51Z tor-error: Backtrace: Remove a Captured(...) from a Display 2024-01-31T14:26:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-31T14:26:51Z urn:sha1:ba2c9eb87e642cf046a664888c9a49027801ae87 Prompted by clippy complaining that the content wasn't ever read other than by the autogenerated Debug impl. tor-error: Correct docs for ErrorReport to reflect improved situation 2023-12-12T13:14:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-12T13:12:52Z urn:sha1:a8b654464c0f339c74ee2511f12efc65b77da27a tor-error: tests: Demonstrate warn_report on bare error and anyhow 2023-12-12T13:14:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-12T12:29:50Z urn:sha1:3de9c7e3b4d22d4c9d860457d1525a124430314f tor-error: ErrorReport: impl for StdError + 'static 2023-12-12T13:14:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-12T12:44:53Z urn:sha1:6cc068c9cdb4e69f03dc07cf4a89f0447d25a9fc tor-error: ErrorReport: remove Sized bound from trait 2023-12-12T12:52:54Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-12T12:43:53Z urn:sha1:4ba92fe87391066312aee9520bacc196e2776aa8 This will let us impl for dyn StdError. tor-error: ErrorReport: move blanket impl code into impl 2023-12-12T12:52:43Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-12T12:42:26Z urn:sha1:c0a15e4f9592a4c0e50c04db6cbea3313ccb7208 This impl can only compile for Self: Sized. This will let us remove the Sized bound from the trait itself. tor-error: ErrorReport: seal 2023-12-12T12:52:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-12T12:40:26Z urn:sha1:00903e22bb9782958135a7061dcfb523e4ebc91f We're going to need to make change to this trait which would be breaking for out-of-crate implementors. This should have been sealed all along. tor-error: Introduce ErrorKind::LocalResourceAlreadyInUse 2023-12-11T15:30:50Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-22T14:07:38Z urn:sha1:99e58a0792df855609f96728d43742f8e07e2132 Our HSS code isn't going to work if you run more than one copy. Soon we'll detect this (via our use of tor_persist). There may be other places this ought to be used. Eg if we get EADDRINUSE from trying to set up a proxy, maybe ... tor-error: fmt_ending_ok: Permit messages ending in ascii ellipsis 2023-11-20T18:22:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-20T18:16:36Z urn:sha1:7c272ed251e475dea6a28e45431a2a0bbdb8185f Tbis will result in "some message ...: the error" which I think is OK. We don't use a Unicode single-character ellipsis because that character can be hard to read at font sizes which are otherwise OK for text, and because use of non-ascii in logfiles and error messages is unecessary and might cause unnecessary trouble (for example, if the log messages end up going somewhere which isn't 100% valid UTF-8). tor-error: fmt_ending_ok: Implement with a direct match 2023-11-20T18:22:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-20T17:45:23Z urn:sha1:d1e71dc2aa96c98c0c1204a8fe19d6a6fe4c7efc Possibly at some point in the past, matching a slice directly wasn't possible. But it is now.