mirrors/arti.git/crates/tor-error/src, branch arti-v1.1.11 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.11 2023-11-20T18:22:30Z tor-error: fmt_ending_ok: Permit messages ending in ascii ellipsis 2023-11-20T18:22:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-20T18:16:36Z urn:sha1:7c272ed251e475dea6a28e45431a2a0bbdb8185f Tbis will result in "some message ...: the error" which I think is OK. We don't use a Unicode single-character ellipsis because that character can be hard to read at font sizes which are otherwise OK for text, and because use of non-ascii in logfiles and error messages is unecessary and might cause unnecessary trouble (for example, if the log messages end up going somewhere which isn't 100% valid UTF-8). tor-error: fmt_ending_ok: Implement with a direct match 2023-11-20T18:22:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-20T17:45:23Z urn:sha1:d1e71dc2aa96c98c0c1204a8fe19d6a6fe4c7efc Possibly at some point in the past, matching a slice directly wasn't possible. But it is now. Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac tor-error: Remove KeystoreFsPermissions variant. 2023-08-08T15:46:20Z Gabriela Moldovan gabi@torproject.org 2023-08-08T15:40:28Z urn:sha1:5d0fb5177f50f87132cbc7d0a95c6f63d4de51d7 According to the `ErrorKind` lumping guidelines, `KeystoreFsPermissions` should be lumped with `FsPermissions`: they represent the same type of error, and their "location" is the same ("Host"). Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1315#note_2916455 Run add_warnings on all files. 2023-08-04T11:45:04Z Nick Mathewson nickm@torproject.org 2023-08-04T11:45:04Z urn:sha1:cec6d0ce33b4b5cebbce57f55faec83397e9c953 retry-error: Provide fmt_error_with_sources in retry-error 2023-07-19T13:16:13Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-18T10:09:54Z urn:sha1:882ce8c8ce74d393b6d95dcede6e69a1a2e86c9b This code came from tor-error. So now tor-error depends on retry-error. clippy: tor-error: Use convert::identity for into_internal! 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T12:38:24Z urn:sha1:fd2e4979be7007f79a0c2c47ac8b89db8ee534cb This launders the closure so that clippy's clippy::redundant_closure_call can't see it. We can't have a local #[allow] because it would be on an expression, which isn't allowed on stable. This avoids having to use more clumsy idioms at call sites. Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Fix warn_report and error_report macros. 2023-07-07T19:46:41Z Nick Mathewson nickm@torproject.org 2023-07-07T19:46:41Z urn:sha1:53c599d50f6394a301f0aa491454bd69ba42a962 Originally they didn't check err.kind(), since err.kind() can never increase their severity. We lost that behavior with !1386, and we became dependent on it with arti!1383. Since they both merged at the same time, CI broke. This patch restores their original behavior. tor-error: tracing module: Use macro to generate macros 2023-07-07T17:38:24Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-07T16:43:26Z urn:sha1:696adc3c9407019a7969eeff9680d8ed668a730b This abolishes some quintuplication. The output is identical except that: * The syntax display in the rustdoc output for the resulting macros seems to have somewhat less whitepsace. * The whimsical error messages in the examples are all identical. Ah well.