mirrors/arti.git/crates/tor-error/src/tracing.rs, branch ios-sqlite-hacksmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks2023-07-07T19:46:41ZFix warn_report and error_report macros.2023-07-07T19:46:41ZNick Mathewsonnickm@torproject.org2023-07-07T19:46:41Zurn:sha1:53c599d50f6394a301f0aa491454bd69ba42a962
Originally they didn't check err.kind(), since err.kind() can never
increase their severity. We lost that behavior with !1386, and we
became dependent on it with arti!1383. Since they both merged at
the same time, CI broke.
This patch restores their original behavior.
tor-error: tracing module: Use macro to generate macros2023-07-07T17:38:24ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-07T16:43:26Zurn:sha1:696adc3c9407019a7969eeff9680d8ed668a730b
This abolishes some quintuplication.
The output is identical except that:
* The syntax display in the rustdoc output for the resulting macros
seems to have somewhat less whitepsace.
* The whimsical error messages in the examples are all identical.
Ah well.
tor-error: tracing module: Fix link to tracing macro2023-07-07T16:48:05ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-07T16:47:50Zurn:sha1:220900a852308042c237317eaca411782f0d0bd6event_report: assert correctness of format ending2023-07-07T13:00:31ZNick Mathewsonnickm@torproject.org2023-07-07T12:47:49Zurn:sha1:023d288ba228b494500eb9c8ee91c6bde5f62a93
(Also, document that this static assertion is the reason why you are
seeing a confusing error message.)
tor-error: Add optional tracing support2023-07-07T13:00:31ZNick Mathewsonnickm@torproject.org2023-07-06T17:48:01Zurn:sha1:7168feefdd41b110646428a087d0b76da990239e
The main contribution here is a set of convenience macros for
logging error `Report`s. Notably, this macros always logs
`Internal` and `BadAspiUsage` errors at `WARN`, unless they
are already at `ERROR` or more.
This is a little tricky because `tracing::event!()` requires
its Level argument to be a constant.