mirrors/arti.git/crates/tor-error/src/tracing.rs, branch arti-v1.7.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.7.02025-08-18T19:45:55Ztor-error: allow only error given to `_report!` macros2025-08-18T19:45:55ZSteven Engleropara@torproject.org2025-08-09T21:27:59Zurn:sha1:8b683380191ca93295c3c8036596df3317f7549c
This is useful when you create an `internal!` error and then immediately
report it. If the `_report!` macro also requires a message, then you
need to provide two messages for the error, which doesn't always make
sense.
This is already possible anyways with `warn_report!(e,)`.
Now you don't need the comma.
tor-error: update `_report!` macros to support tracing fields2025-08-18T19:45:55ZSteven Engleropara@torproject.org2025-08-09T00:52:18Zurn:sha1:54ef60d3f8dca50973b77767d0a101006cee52c0
This requires that we put the error in a field. There are two issues
that we'll fix in the next two commits:
1. Errors are no longer formatted with `ErrorReport`.
2. Errors will be in the first field, but long (or multiline) error
messages will cause other fields to be pushed to the end where
they're harder to find.
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
Run maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320ctor-error: tests: Demonstrate warn_report on bare error and anyhow2023-12-12T13:14:22ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-12T12:29:50Zurn:sha1:3de9c7e3b4d22d4c9d860457d1525a124430314ftor-error: fmt_ending_ok: Permit messages ending in ascii ellipsis2023-11-20T18:22:30ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-20T18:16:36Zurn:sha1:7c272ed251e475dea6a28e45431a2a0bbdb8185f
Tbis will result in "some message ...: the error" which I think is OK.
We don't use a Unicode single-character ellipsis because that
character can be hard to read at font sizes which are otherwise OK for
text, and because use of non-ascii in logfiles and error messages is
unecessary and might cause unnecessary trouble (for example, if the
log messages end up going somewhere which isn't 100% valid UTF-8).
tor-error: fmt_ending_ok: Implement with a direct match2023-11-20T18:22:30ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-20T17:45:23Zurn:sha1:d1e71dc2aa96c98c0c1204a8fe19d6a6fe4c7efc
Possibly at some point in the past, matching a slice directly wasn't
possible. But it is now.
Fix warn_report and error_report macros.2023-07-07T19:46:41ZNick Mathewsonnickm@torproject.org2023-07-07T19:46:41Zurn:sha1:53c599d50f6394a301f0aa491454bd69ba42a962
Originally they didn't check err.kind(), since err.kind() can never
increase their severity. We lost that behavior with !1386, and we
became dependent on it with arti!1383. Since they both merged at
the same time, CI broke.
This patch restores their original behavior.
tor-error: tracing module: Use macro to generate macros2023-07-07T17:38:24ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-07T16:43:26Zurn:sha1:696adc3c9407019a7969eeff9680d8ed668a730b
This abolishes some quintuplication.
The output is identical except that:
* The syntax display in the rustdoc output for the resulting macros
seems to have somewhat less whitepsace.
* The whimsical error messages in the examples are all identical.
Ah well.
tor-error: tracing module: Fix link to tracing macro2023-07-07T16:48:05ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-07T16:47:50Zurn:sha1:220900a852308042c237317eaca411782f0d0bd6