mirrors/arti.git/crates/tor-error/src/internal.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-07-10T14:03:16Ztor-error: Fix clippy warnings2026-07-10T14:03:16Zhjrgrn3874-hjrgrn@gitlab.torproject.org2026-07-10T13:56:14Zurn:sha1:b81cdc3362464564369554ad95f2e6d1b602837bmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
Fix grammar typos2026-03-15T20:19:00ZTobias Stoeckmanntobias@stoeckmann.org2026-03-15T20:06:47Zurn:sha1:53e76b87646bc96da316fe699c2226662cce4bf2Fix word duplicate typos2026-03-15T20:18:56ZTobias Stoeckmanntobias@stoeckmann.org2026-03-15T20:05:34Zurn:sha1:2173207d8b909d1afdc55adda13faac13cdded0ftor-error: Provide new `bug_context` method on Bug and Result<_, Bug>2025-12-01T15:21:19ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-01T10:14:56Zurn:sha1:99c79ccb73f69a245e8bbbed94b763b8777d4826
This allows call sites which have a `Bug` to add additional context,
beyond just the stack trace.
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
tor-error: use `Display` for backtrace captured by `BugRepr`2024-10-29T14:06:49ZSteven Engleropara@torproject.org2024-10-29T01:59:15Zurn:sha1:c91d067d395ed9a1e2385fcaf9c15dbb578a575f
Before:
```text
2024-10-29T01:57:31Z ERROR arti: error: internal error (bug) at crates/arti/src/lib.rs:378:27: foo
Backtrace [{ fn: "tor_error::internal::ie_backtrace::capture", file: "./crates/tor-error/src/internal.rs", line: 21 }, { fn: "tor_error::internal::Bug::new_inner", file: "./crates/tor-error/src/internal.rs", line: 105 }, { fn: "tor_error::internal::Bug::new", file: "./crates/tor-error/src/internal.rs", line: 94 }, { fn: "arti::main_main", file: "./crates/arti/src/lib.rs", line: 378 }, ...
```
After:
```text
2024-10-29T01:58:23Z ERROR arti: error: internal error (bug) at crates/arti/src/lib.rs:378:27: foo
0: tor_error::internal::ie_backtrace::capture
at ./crates/tor-error/src/internal.rs:21:27
1: tor_error::internal::Bug::new_inner
at ./crates/tor-error/src/internal.rs:105:24
2: tor_error::internal::Bug::new
at ./crates/tor-error/src/internal.rs:94:9
3: arti::main_main
at ./crates/arti/src/lib.rs:378:27
...
```
tor-error: Disable backtraces under miri, even if cargo feature enabled2024-10-08T15:53:28ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-07T11:45:24Zurn:sha1:856b65f24b31e9500d7ef5a84e168b423e06d862Use std::backtrace instead of backtrace crate2024-08-01T12:18:40ZRobin Leander Schröder1473-rls@gitlab.torproject.org2024-08-01T12:07:36Zurn:sha1:9f31e6b650f004ccf88446e8b2a39f1381995c09
Removes resolve_backtraces from rtmock since it is no longer needed as
stdlib's backtraces automatically lazily resolve without needing a &mut.
Run maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c