mirrors/arti.git/crates/tor-error/src/internal.rs, branch ios-sqlite-hacks mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks 2023-08-23T09:34:00Z Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac clippy: tor-error: Use convert::identity for into_internal! 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T12:38:24Z urn:sha1:fd2e4979be7007f79a0c2c47ac8b89db8ee534cb This launders the closure so that clippy's clippy::redundant_closure_call can't see it. We can't have a local #[allow] because it would be on an expression, which isn't allowed on stable. This avoids having to use more clumsy idioms at call sites. Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Add TODO comments about possibly migrating away from the backtrace crate. 2023-07-05T20:39:11Z Nick Mathewson nickm@torproject.org 2023-07-05T20:39:11Z urn:sha1:afa51fd5ca3c625fbe71e5991e38d8056427d282 Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. tor-error: tests: Add a test case for Report and Bug wrapping 2022-12-15T14:37:08Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-14T14:05:46Z urn:sha1:8a28cb2d14aa3f6ca3e251b479f4f29be3dd8118 Allow "clippy::single_char_pattern" in tests. 2022-10-12T12:50:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-11T13:00:07Z urn:sha1:82ad9eea5f80331d0e26a7d5ccfeed9e58a615fb This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome. tor-error::internal: Remove a redundant suppression 2022-09-30T16:08:14Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-09-27T16:35:27Z urn:sha1:98f92d870ea57a578bc9622a8079f09824da8940 Spotted this in passing. force no inlining on internal_macro_test 2022-09-09T15:29:59Z trinity-1686a trinity@deuxfleurs.fr 2022-09-09T15:29:59Z urn:sha1:cb9f085f779d1d821adf8a145177d8aa9c4e2518 it may fix this test when running in release, where the function gets inlined, so its name does not appear in the backtrace Add a dbg!() to diagnose #570. 2022-09-08T13:58:05Z Nick Mathewson nickm@torproject.org 2022-09-08T13:58:05Z urn:sha1:a7d9d2ceb1136125195d0db65cb1fcbd472fd4da This won't fix anything, but it will let us see what the backtrace looks like when it fails.