mirrors/arti.git/crates/tor-error/src/internal.rs, branch arti-v1.4.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.42024-10-29T14:06:49Ztor-error: use `Display` for backtrace captured by `BugRepr`2024-10-29T14:06:49ZSteven Engleropara@torproject.org2024-10-29T01:59:15Zurn:sha1:c91d067d395ed9a1e2385fcaf9c15dbb578a575f
Before:
```text
2024-10-29T01:57:31Z ERROR arti: error: internal error (bug) at crates/arti/src/lib.rs:378:27: foo
Backtrace [{ fn: "tor_error::internal::ie_backtrace::capture", file: "./crates/tor-error/src/internal.rs", line: 21 }, { fn: "tor_error::internal::Bug::new_inner", file: "./crates/tor-error/src/internal.rs", line: 105 }, { fn: "tor_error::internal::Bug::new", file: "./crates/tor-error/src/internal.rs", line: 94 }, { fn: "arti::main_main", file: "./crates/arti/src/lib.rs", line: 378 }, ...
```
After:
```text
2024-10-29T01:58:23Z ERROR arti: error: internal error (bug) at crates/arti/src/lib.rs:378:27: foo
0: tor_error::internal::ie_backtrace::capture
at ./crates/tor-error/src/internal.rs:21:27
1: tor_error::internal::Bug::new_inner
at ./crates/tor-error/src/internal.rs:105:24
2: tor_error::internal::Bug::new
at ./crates/tor-error/src/internal.rs:94:9
3: arti::main_main
at ./crates/arti/src/lib.rs:378:27
...
```
tor-error: Disable backtraces under miri, even if cargo feature enabled2024-10-08T15:53:28ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-07T11:45:24Zurn:sha1:856b65f24b31e9500d7ef5a84e168b423e06d862Use std::backtrace instead of backtrace crate2024-08-01T12:18:40ZRobin Leander Schröder1473-rls@gitlab.torproject.org2024-08-01T12:07:36Zurn:sha1:9f31e6b650f004ccf88446e8b2a39f1381995c09
Removes resolve_backtraces from rtmock since it is no longer needed as
stdlib's backtraces automatically lazily resolve without needing a &mut.
Run maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320ctor-error: Backtrace: Remove a Captured(...) from a Display2024-01-31T14:26:51ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-31T14:26:51Zurn:sha1:ba2c9eb87e642cf046a664888c9a49027801ae87
Prompted by clippy complaining that the content wasn't ever read other
than by the autogenerated Debug impl.
Run maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9acclippy: tor-error: Use convert::identity for into_internal!2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T12:38:24Zurn:sha1:fd2e4979be7007f79a0c2c47ac8b89db8ee534cb
This launders the closure so that clippy's
clippy::redundant_closure_call can't see it.
We can't have a local #[allow] because it would be on an expression,
which isn't allowed on stable.
This avoids having to use more clumsy idioms at call sites.
Run maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0Add TODO comments about possibly migrating away from the backtrace crate.2023-07-05T20:39:11ZNick Mathewsonnickm@torproject.org2023-07-05T20:39:11Zurn:sha1:afa51fd5ca3c625fbe71e5991e38d8056427d282Allow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.