mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.1 2026-07-22T12:25:53Z 2026-07-22T12:25:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-07-22T12:25:53Z urn:sha1:e64263b921638ceb9c6adf3967fdde39e0a73db2 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. 2026-04-28T16:27:56Z Clara Engler cve@cve.cx 2026-04-28T08:09:13Z urn:sha1:67c4e02d595fed7ce3afc06e43f2577244b67ff4 If extra-infos is set to NULL, which might be the case for micro descriptors or even router descriptors because the field is optional there, this SQL query fails because it cannot LEFT JOIN server.extra_unsigned_sha1 when this field is NULL. To fix this, we simply add an additional clause to the WHERE statement that filters such rows out. 2026-04-27T15:46:58Z Clara Engler cve@cve.cx 2026-04-14T09:01:32Z urn:sha1:6b26ebb430da64239c1698798b2ee1543129cba7 This commit makes use of the presence of only one descriptor hash inside consensus_router_descriptor_member by adding a respective AND clause to the select statements of missing descriptors to only select the rows with a non-null SHA-1 (or SHA-2 for the sake of microdescs) in the consensus_router_descriptor_member table. This is defensive programming and should not be required in practice because the docid as well as the "XOR" CHECK should already ensure that this value is always non-NULL. However, if it still happens and slips through, the statement would return NULL rows, which is not what we want and was previously prevented by ensuring this field was never NULL in the first place. 2026-04-27T15:46:58Z Clara Engler cve@cve.cx 2026-04-14T08:49:56Z urn:sha1:0b07bd3ee6a19af1025c02c52971a9071b937620 This commit modifies the consensus_router_descriptor_member table in the database schema, removing the NOT NULL constraint on unsigned_sha1 and unsigned_sha2 by replacing it with a new CHECK constraint that checks that either one of them is set but not both. The reason for this is as follows: We are going to use this table to compute the queue of missing descriptors, which means that we can only populate this table with the data we know from the consensus. The consensus however tells us only one of those hashes, namely sha1 in the case of a consensus-ns and sha2 in the case of a consensus-md. In other words: This commit can also be seen as an effort to change the design of the operation in such a way that the queue is obtained directly from the database and not computed at the start during state transition. 2026-04-21T14:52:33Z Nick Mathewson nickm@torproject.org 2026-04-19T20:06:44Z urn:sha1:80460f968db2c90d3d1dbc6a1592bff5e68f8de9 Rust 1.95 warns us that this is an experimental API that could be stabilized in the future. 2026-03-24T16:04:08Z Tobias Stoeckmann tobias@stoeckmann.org 2026-03-24T16:04:08Z urn:sha1:1fb2b8dd4aee7c943ce90d6631be473f2a296fe6 Typos found with codespell 2026-03-09T08:31:28Z Clara Engler cve@cve.cx 2026-02-25T11:16:09Z urn:sha1:ec1dc8a0dba0c7e2389dcf6291c80b5626472354 2026-03-09T08:31:28Z Clara Engler cve@cve.cx 2026-02-25T10:41:43Z urn:sha1:c3738787191c3f21b74e592ea67cce6a60f1af53 This commit replaces the uses of sha1, sha2, and sha3 with their respective pedants from tor-llcrypto for better consistency. Internally, they still use the same logic and underlying crates but let's use this encapsulation nonetheless. 2026-03-09T08:31:28Z Clara Engler cve@cve.cx 2026-02-25T10:29:55Z urn:sha1:27a1ebcef3263522acb9a02763f52eadf113fe4c