mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.0 2022-05-06T14:03:15Z 2022-05-06T14:03:15Z Nick Mathewson nickm@torproject.org 2022-05-06T14:03:15Z urn:sha1:7b93091f57f43ec8543a17052d60a2c8f7f2b0cc * Except for safelog and fs-mistrust, which are new. 2022-05-06T12:36:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-06T12:18:03Z urn:sha1:030289481f79d7b1de4084e485b1793042b36ee8 For reference, the git source for this crate (and the others in its workspace) currently lives in my personal github account (ijackson). If this fork turns out to be long-lived and gains features and/or users, it would be good to move it to a gitlab somewhere. I have granted Nick crate ownership on the crates.io system. 2022-05-05T09:35:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T16:45:25Z urn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861 * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.) 2022-05-04T16:18:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:20:08Z urn:sha1:4ad4cae4180981856676f675e32117b683518f4e And drop the ad-hoc orport() method. This brings FallbackDir's orports field in line with our list builder API. The general semver note in "configuation" seems to cover most of this. 2022-05-04T12:50:12Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T11:00:24Z urn:sha1:9214eb5db2b73abd4417d6a5261a39c32758abd5 This type was returned by the public DownloadSchedule::builder function. But the only thing that seems to have noticed that the type name itself wasn't exported, was rustdoc. Hmmm. 2022-05-04T12:50:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T12:32:35Z urn:sha1:4bca91271558d950092fb1ac51c1316655d293cb The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements). 2022-05-04T12:41:39Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-03T14:28:57Z urn:sha1:ff624f6081cc339d12b82c7a753bfdfdf88f93ed Previously this field was differently named to its serde and to its accessors. We are about to introduce a macro_rules macro which will provide list accessors and we don't want that macro to have a field renaming feature. So stop renaming the field. 2022-04-27T14:31:08Z eta tor@eta.st 2022-04-27T14:31:08Z urn:sha1:6f787e1e7707c2125a5d0df457e7894f944f4aa6 derive_builder: Use git dep everywhere, rather than cargo patch See merge request tpo/core/arti!477 2022-04-27T13:57:59Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-27T13:44:59Z urn:sha1:a97ad69855cdf1931e29cc024a79336448f50990 The `[patch]` approach causes the tree not to build when used as a dependency, unless the `[patch]` is replicated into the depending project. Instead, replace our `derive_builer =` dependencies with a reference to a specific git commit: perl -i~ -pe 'next unless m/^derive_builder/; s#"(0\.11\.2)"#{ version = "$1", git = "https://github.com/ijackson/rust-derive-builder", rev = "ba0c1a5311bd9f93ddf5f5b8ec2a5f6f03b22fbe" }#' crates/*/Cargo.toml Note that the commitid has changed. This is because derive_builder is in fact a workspace of 4 crates. 3 of them are of interest to arti itself (the 4th exists only for testing). So the same "add git revision" treatment had to be done to the `derive_builder` and `derive_builder_macro` crates. Each dependency edge involves a new commit in the derive_builder workspace, since we can't create a git commit containing its own commitid. (We want to use commits, rather than a branch, so that what we are depending on is actually properly defined, and not subject to the whims of my personal github namespace.) There are no actual code changes in derive_builder. 2022-04-27T12:52:13Z Samanta Navarro ferivoz@riseup.net 2022-04-23T11:51:44Z urn:sha1:c53818d496c910de4dfc4bc8d1f53e419fbf7408