mirrors/arti.git/crates/tor-dirmgr/src, branch arti-v2.5.1mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.12026-07-23T15:28:33ZMerge branch 'refactor-tor-dirmgr-0' into 'main'2026-07-23T15:28:33ZJim Newsomejnewsome@torproject.org2026-07-23T15:28:33Zurn:sha1:45699d1c92acf0ab3f35e6de9edda7ad5d63d2f1
tor-dirmgr: Refactor function download
See merge request tpo/core/arti!4204tor-checkable: Rename `TimeBound::is_valid_at` to `check_valid_at`2026-07-23T10:13:34ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-20T16:51:12Zurn:sha1:b97c30a9e666d40601d76b645f44abc6adf42fe9
I find this names confusing. To my mind "is" implies a function
returning `bool`.
tor-checkable: Rename `TimeBound::check_valid_*` to `if_valid_*`2026-07-23T10:13:34ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-20T16:40:18Zurn:sha1:ca37f30a097696ce2ebd4e9945a4bdaebe086b31
I find these names confusing. To my mind "check" implies a function
returning `Result<(), _>`.
Some other APIs use `unwrap` here but I think `if` is good.
tor-checkable: TimeBound: Make dangerously_into_parts return TimeRange2026-07-23T10:13:34ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-20T10:38:50Zurn:sha1:632e87a5355305d6200fb3d3f78555f244139c37
It is better to return a more cooked type. `TimeRange` aka
`TimeRangeBound<()>` is perfect for this.
tor-dirmgr: Refactor bootstrap::download2026-07-23T07:02:42Zhjrgrn3874-hjrgrn@gitlab.torproject.org2026-07-10T09:01:08Zurn:sha1:b683ff599299846a9cee5e0e72e47ca6c91705b7
- Add helper functions: perform_download, advance_state, apply_state, and
update_state
- Add enum used in said helper functions: DownloadOutcome and AdvanceStateError
- Add minor improvements on the readability of the entire sub-module
Use new TimeBound name throughout the tree2026-07-16T15:47:50ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-16T14:32:14Zurn:sha1:5f57903ab4a8c280acf8a5bec274c50d5f544fd6Merge branch 'remove-lint' into 'main'2026-07-15T18:30:16ZJim Newsomejnewsome@torproject.org2026-07-15T18:30:16Zurn:sha1:b1e6787b0bb05b8fe1f8b87716f1bd2b478eb602
Removed unnecessary lint
Closes #2556
See merge request tpo/core/arti!4210Remove now-unneeded allow(clippy::cognitive_complexity)2026-07-15T18:05:29ZJim Newsomejnewsome@torproject.org2026-07-15T18:05:29Zurn:sha1:e4c00405e703b6e274af2e3cfb000cab5a7c7837add_warning: add reference to arti#25562026-07-15T17:56:49ZJim Newsomejnewsome@torproject.org2026-07-15T17:56:49Zurn:sha1:6d333d6e6f0bf4d75fdc81e8865e06f6537d5af6Removed unnecessary lint2026-07-15T17:16:51Zpryty26238962075+pryty26@users.noreply.github.com2026-07-15T17:07:59Zurn:sha1:d12e408c1d62f29e58647c91a2714c49e3004cc4
Removed unnecessary lint