mirrors/arti.git/crates/tor-dirmgr/src, branch arti-v1.2.5

Merge branch 'tolerate_missing_blob' into 'main'

2024-06-18T14:26:40Z

dirmgr::storage: Treat a missing blob file as an absent object. Closes #1466 See merge request tpo/core/arti!2200

sqlite: (style) Use consistent casing on "ExtDocs"

2024-06-18T13:48:49Z

SQL is case-insensitive, but it is still nice to be consistent.

dirmgr: Limit the number of mds that we will fetch from sqlite at once.

2024-06-12T16:48:27Z

This should help limit our memory usage when restarting from cache. Possible (imperfect) solution for #1027.

dirmgr: split out the loading part of load_once into a new function.

2024-06-12T16:43:28Z

storage: Remove orphaned files from dir_blobs

2024-06-12T15:26:12Z

This patch removes files from dir_blobs if they are not referenced from the database, or if their filenames are not valid UTF-8. (If they were not valid UTF-8, we wouldn't have put them in our database.) To ensure that there can't be any race conditions, we only do this when the file is a bit old.

dirmgr: create temporary testing stores with correct paths.

2024-06-12T15:12:01Z

Previously, we were putting an (optional) db.sql file and our blobs into the same path, which is not what we do outside of our tests.

dirmgr::storage: Enable foreign keys on our sqlite connections.

2024-06-12T14:19:36Z

Without this, "ON DELETE CASCADE" will do nothing. Part of fixing #1466.

dirmgr::storage: Treat a missing blob file as an absent object.

2024-06-12T14:18:20Z

Previously it was counted as a hard error, which would cause an absolute failure to start if a blob file had been deleted improperly -- for example, by a renegade cache-cleaner that had decided to remove the largest files it could find. Upon encountering a missing blob, we remove it from the database as well: if we did not, then unavailable consensuses could still cause us to try to fetch consensus diffs, because their rows would still be present. Fixes #1466.

dirauth: Add new faravahar authority

2024-05-30T13:13:19Z

Related to C-tor MR: https://gitlab.torproject.org/tpo/core/tor/-/merge_requests/819 Signed-off-by: David Goulet

DirMgr: Clarify dead_code status on storage methods.

2024-05-14T14:49:01Z

Per comments on #1383, we're keeping these methods. This commit replaces the "TODO" comments with comments explaining why it's okay that this methods are unused. Part of #1383.