mirrors/arti.git/crates/tor-dirmgr/src, branch arti-v1.2.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.0 2024-02-26T12:57:25Z Upgrade to latest event-listener 2024-02-26T12:57:25Z Nick Mathewson nickm@torproject.org 2024-02-26T12:57:25Z urn:sha1:deeea15306b98b0ba94642cae02a26c644119e70 educe: Use std's default for enums where default variant is unit 2024-02-12T11:38:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-02-12T11:07:42Z urn:sha1:c35c60f848154e80f23ba95a989ff2f9d2594e6a Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible. clippy: Use Result::cloned in several places 2024-01-31T14:35:58Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-31T14:27:47Z urn:sha1:6fbc7e0ab48c5a424d13944f1103f18e3ec33913 tor-dirmgr: Simplify a clone call (fmt) 2024-01-31T14:35:58Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-31T14:35:26Z urn:sha1:7eaa11c4192c25db911a49b454c10f5f91af471d tor-dirmgr: Simplify a clone call 2024-01-31T14:35:58Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-31T14:30:06Z urn:sha1:8e8953bae4f45133c310b7c4d3e688db664b904e Prompted by clippy. dirmgr: Make the `dir_mgr_config` method public 2024-01-09T10:28:04Z Emil Engler me@emilengler.com 2023-12-30T10:45:04Z urn:sha1:619181e2e1a8982220f04a3c2b54963fd3ec575b This commit makes the `dir_mgr_config` method of the `TorClientConfig` struct public. It might be questionable whether we should make this function public or switch to a `TryInto` trait in general, which also seems like an even Rustier solution Rustier solution. Fixes #1175 clippy nightly: For now, locally allow implied_bounds_in_impls 2024-01-02T15:04:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-02T14:51:41Z urn:sha1:145534e0441764ceb5feab25ed4c537a19972c4b Filed https://gitlab.torproject.org/tpo/core/arti/-/issues/1177 proposing a final fix. clippy nightly: For now, locally allow blocks_in_conditions 2024-01-02T15:04:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-02T14:51:30Z urn:sha1:2e459400ebc4cb40622cf2eb42803afafbc05ad4 Filed https://gitlab.torproject.org/tpo/core/arti/-/issues/1176 proposing a final fix. clippy: Replace many calls to .get(0) with .first() 2024-01-02T13:56:08Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-02T12:48:44Z urn:sha1:b9da8cf60618b16c021d3ecf1ec24e2dce56aff5 FTR I don't think agree with clippy on this question, but then I often don't. tor-persist: Provide FsMistrustErrorExt, and use it 2023-12-13T17:02:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-07T16:18:32Z urn:sha1:76bd3c0f4dc5886dbc4a11304a87661d1252b829 This code needs fs_mistrust::Error and tor_error::ErrorKind. I think we probably don't want fs_mistrust to depend on tor_error or vice versa. tor_persist is approximately the place where these two threads of thought come together, and it's currently the lowest place where this is needed. Use it in tor-dirmgr too, which is currently the other place that embodies this knowledge about fs_mistrust::Error.