mirrors/arti.git/crates/tor-dirmgr/src, branch arti-v1.1.3

Sort out some TODOs in bdtest.rs

2023-03-21T13:08:14Z

Fix a bunch of needless-conversion warnings.

2023-03-10T12:09:50Z

Apparently 1.68 now warns when you call into_iter() on something that's already an iterator. Fair enough. Let's stop doing that.

tor-dirmgr: Don't try to mark consensus usable in a read-only store.

2023-03-08T12:08:17Z

Doing this means that any attempt to use a read-only store would crash as soon as it found that the consensus was usable. It seems that this bug was introduced at some point doing all the dirmgr refactors we did over the past year. Perhaps there should be a test for running with a read-only store. Fixes #779

tor-dirmgr: Work around an apparent regression in `time`.

2023-02-17T19:36:19Z

Some code in our tests that worked fine with time 0.3.17 no longer works with 0.3.19, despite the semver. See https://github.com/time-rs/time/issues/552 for the upstream bug.

tor-netdoc: Change fill_from_previous_netdir

2023-02-09T12:56:18Z

* Remove the return value, which was not used anywhere. Also remove the code to calculate the return value. * Take an Arc rather than a reference. We are going to want this for HS support. This has no overall effect on the lifetime of the4 Arc, which was owned at the one call site and then imediately dropped. * Change the documentation to explain what the function's role is in the netdir API, rather than the fiddly details of what it actually does internally. Relegate the latter to a code comment. (When we have HS, this will do more, or, at least, make further arrangements.)

Use ErrorReport - run rustfmt

2023-01-30T18:52:32Z

Split off for ease of review and possible rebase.

Use ErrorReport's .report() for two errors in error! in bridgedesc.rs

2023-01-30T18:52:32Z

No functional change, just using the new idiom.

Use ErrorReport for errors in warn! in tor-dirmgr

2023-01-30T18:52:32Z

Use ErrorReport for errors in info! in tor-dirmgr

2023-01-30T18:04:57Z

"Fix" remaining unchecked-subtraction warnings.

2023-01-27T14:16:41Z

In both cases I think it's fine to panic; but it's best to do so explicitly.