mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.0 2022-05-05T09:35:52Z 2022-05-05T09:35:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T16:45:25Z urn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861 * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.) 2022-05-04T16:18:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:20:08Z urn:sha1:4ad4cae4180981856676f675e32117b683518f4e And drop the ad-hoc orport() method. This brings FallbackDir's orports field in line with our list builder API. The general semver note in "configuation" seems to cover most of this. 2022-05-04T12:50:12Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T11:00:24Z urn:sha1:9214eb5db2b73abd4417d6a5261a39c32758abd5 This type was returned by the public DownloadSchedule::builder function. But the only thing that seems to have noticed that the type name itself wasn't exported, was rustdoc. Hmmm. 2022-05-04T12:50:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T12:32:35Z urn:sha1:4bca91271558d950092fb1ac51c1316655d293cb The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements). 2022-05-04T12:41:39Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-03T14:28:57Z urn:sha1:ff624f6081cc339d12b82c7a753bfdfdf88f93ed Previously this field was differently named to its serde and to its accessors. We are about to introduce a macro_rules macro which will provide list accessors and we don't want that macro to have a field renaming feature. So stop renaming the field. 2022-04-27T12:52:13Z Samanta Navarro ferivoz@riseup.net 2022-04-23T11:51:44Z urn:sha1:c53818d496c910de4dfc4bc8d1f53e419fbf7408 2022-04-26T18:47:08Z Nick Mathewson nickm@torproject.org 2022-04-26T18:47:08Z urn:sha1:5484bcc21f89d19d30e6351670c36359c132f718 DownloadSchedule: Introduce Builder See merge request tpo/core/arti!473 2022-04-26T18:01:20Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T17:59:10Z urn:sha1:4a32bcd4d3870b2ea5137d6ffeb70bebadcf5ccb As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/473#note_2798464 2022-04-26T17:40:05Z Nick Mathewson nickm@torproject.org 2022-04-26T17:40:05Z urn:sha1:4643e1dd249841f590e441cb9a9e8ef6ba750cba 2022-04-26T14:32:20Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T14:26:06Z urn:sha1:72eaa9fc30e00137e1ddfaa0ab99731d8a6ae705 These fields are pub. Retain two convenience accessor functions that access sub-fields of network.