mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.2.0 2022-03-31T12:07:50Z 2022-03-31T12:07:50Z Nick Mathewson nickm@torproject.org 2022-03-31T12:07:50Z urn:sha1:c5e5fc155396c121f512572057ff73e1d0d97122 Replace the next delay field immediately rather than taking it and _then_ setting it. This way, it's never in an incorrect state. 2022-03-30T17:56:36Z Nick Mathewson nickm@torproject.org 2022-03-30T17:56:36Z urn:sha1:6e8c982ab5dabf67fffecf99a53755e1488ee404 The previous algorithm had two flaws: * It would wait even after the final attempt, when there were no more retries to do. * It would fail to wait between attempts if an error occurred. This refactoring fixes both of these issues, and adds some comments. 2022-03-30T14:41:39Z Nick Mathewson nickm@torproject.org 2022-03-29T14:55:20Z urn:sha1:6282df34fb00c3b8b686553e05f8d3172b017ed0 The FirstHopId type now records an enum that stores whether the hop is a guard or a fallback. This change addresses concerns about remembering to check the type or source of an Id before passing it down to the FallbackState or GuardSet. Making this change required an API change, so that dirmgr can report success/failure status without actually knowing whether it's using a fallback or a guard. 2022-03-30T14:40:59Z Nick Mathewson nickm@torproject.org 2022-03-29T13:05:39Z urn:sha1:13af6134f6180f7241daca9206fa49ed5f26829d This is preparation for having separate GuardId and FirstHopId types that distinguish which back-end they index. 2022-03-30T14:40:12Z Nick Mathewson nickm@torproject.org 2022-03-26T00:32:52Z urn:sha1:bdd129f23094b58b738c87d4655783004fac2274 2022-03-30T14:39:09Z Nick Mathewson nickm@torproject.org 2022-03-25T23:19:57Z urn:sha1:bfb2353a8f627b189e104e606b3284fdfaa6d98b We do this by creating a new FallbackSet type that includes status information, and updating the GuardMgr APIs to record success and failure about it when appropriate. We can use this to mark FallbackDirs retriable (or not). With this change, FallbackDir is now stored internally as a Guard in the GuardMgr crate. That's fine: the FallbackDir type really only matters for configuration. 2022-03-30T14:39:09Z Nick Mathewson nickm@torproject.org 2022-03-25T21:00:40Z urn:sha1:e48f4f3a93a04562423e3ad4955d4586de28acd4 This is the final step in allowing the CircMgr to use the GuardMgr's view of the fallbacks. Compilation is restored and tests pass. 2022-03-30T14:39:06Z Nick Mathewson nickm@torproject.org 2022-03-25T20:44:12Z urn:sha1:9da43189f36b19681d10b78ef982c52c929b4573 The guard manager is responsible for handing out the first hops of tor circuits, keeping track of their successes and failures, and remembering their states. Given that, it makes sense to store this information here. It is not yet used; I'll be fixing that in upcoming commits. Arguably, this information no longer belongs in the directory manager: I've added a todo about moving it. This commit will break compilation on its own in a couple of places; subsequent commits will fix it up. 2022-03-30T14:34:48Z Nick Mathewson nickm@torproject.org 2022-03-25T17:38:01Z urn:sha1:80b65c3a4d4108c6b4b0cb91722f89c8e5859b7d This is the logical place for it, I think: the GuardMgr's job is to pick the first hop for a circuit depending on remembered status for possible first hops. Making this change will let us streamline the code that interacts with these objects. 2022-03-30T14:02:13Z eta tor@eta.st 2022-03-30T14:02:13Z urn:sha1:5d27710ef1bdd80a9260204acd25d1f11834141e Remove allow(clippy::disallowed_methods) lint flag. See merge request tpo/core/arti!437