mirrors/arti.git/crates/tor-dirmgr/src/storage, branch arti-v1.2.7 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.7 2024-07-31T08:59:43Z Merge branch 'sqlite-race' into 'main' 2024-07-31T08:59:43Z gabi-250 gabi@torproject.org 2024-07-31T08:59:43Z urn:sha1:041ef9b3068d281bbcdd32f65b57215f835dbb42 tor-dirmgr: Return an error if storage is readonly and DB is missing/incompatbile. Closes #1497 See merge request tpo/core/arti!2283 tor-dirmgr: Use Path::try_exists() instead of Path::exists(). 2024-07-30T14:20:38Z Gabriela Moldovan gabi@torproject.org 2024-07-30T14:17:24Z urn:sha1:e2b7ac36df973ef97b3740e51acd9cd1da80a357 tor-dirmgr: Replace from_conn impl with a call to from_conn_internal helper. 2024-07-30T10:00:48Z Gabriela Moldovan gabi@torproject.org 2024-07-29T15:42:23Z urn:sha1:89331d0862f347427507360c2f7e1a23b1dd8f32 tor-dirmgr: Return an error if storage is readonly and DB is missing/incompatbile. 2024-07-30T10:00:48Z Gabriela Moldovan gabi@torproject.org 2024-07-23T15:16:21Z urn:sha1:d7b92bd91d117deb6be85f82bfadd1bbae463a2c This fixes a bug in `SqliteStore`'s constructor: previously, it would unconditionally try to create the missing database, even if it didn't have write access. As a result, it was impossible to reliably start multiple concurrent arti processes configured with the same (empty or nonexistent) cache_dir, because many of them would fail with errors such as ``` attempt to write a readonly database: Error code 8: Attempt to write a readonly database ``` Returning a `LocalResourceAlreadyInUse` error kind here enables us to leverage the retry loop from `TorClientBuilder::create_unbootstrapped` (which retries on local resource errors if `local_resource_timeout` is set). Closes #1497 tor-dirmgr: Add some duplicate dead code allows 2024-07-08T10:36:25Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-07-08T10:22:49Z urn:sha1:168cfc2c6e42182a703e51ea61b50dc82a2dfbe4 Sadly, rustc seems to want us to mark this allow in several places. sqlite: (style) Use consistent casing on "ExtDocs" 2024-06-18T13:48:49Z Nick Mathewson nickm@torproject.org 2024-06-18T13:48:49Z urn:sha1:83430d6b2da2cfc3d4dc6ea4c621c07d1f80357e SQL is case-insensitive, but it is still nice to be consistent. storage: Remove orphaned files from dir_blobs 2024-06-12T15:26:12Z Nick Mathewson nickm@torproject.org 2024-06-12T15:26:12Z urn:sha1:8a7e0b6225a1a70803457f4cd13bda0c4b47f024 This patch removes files from dir_blobs if they are not referenced from the database, or if their filenames are not valid UTF-8. (If they were not valid UTF-8, we wouldn't have put them in our database.) To ensure that there can't be any race conditions, we only do this when the file is a bit old. dirmgr: create temporary testing stores with correct paths. 2024-06-12T15:12:01Z Nick Mathewson nickm@torproject.org 2024-06-12T15:12:01Z urn:sha1:06f9af078639d650df6c9b7add640b95cf772368 Previously, we were putting an (optional) db.sql file and our blobs into the same path, which is not what we do outside of our tests. dirmgr::storage: Enable foreign keys on our sqlite connections. 2024-06-12T14:19:36Z Nick Mathewson nickm@torproject.org 2024-06-12T14:19:36Z urn:sha1:16f8757cc5173788563931c575b507a009ed0f28 Without this, "ON DELETE CASCADE" will do nothing. Part of fixing #1466. dirmgr::storage: Treat a missing blob file as an absent object. 2024-06-12T14:18:20Z Nick Mathewson nickm@torproject.org 2024-06-12T13:51:17Z urn:sha1:8801c121ad79a7a59058aef69eff70c9537df1ee Previously it was counted as a hard error, which would cause an absolute failure to start if a blob file had been deleted improperly -- for example, by a renegade cache-cleaner that had decided to remove the largest files it could find. Upon encountering a missing blob, we remove it from the database as well: if we did not, then unavailable consensuses could still cause us to try to fetch consensus diffs, because their rows would still be present. Fixes #1466.