mirrors/arti.git/crates/tor-dirmgr/src/storage, branch arti-v1.2.5 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.5 2024-06-18T13:48:49Z sqlite: (style) Use consistent casing on "ExtDocs" 2024-06-18T13:48:49Z Nick Mathewson nickm@torproject.org 2024-06-18T13:48:49Z urn:sha1:83430d6b2da2cfc3d4dc6ea4c621c07d1f80357e SQL is case-insensitive, but it is still nice to be consistent. storage: Remove orphaned files from dir_blobs 2024-06-12T15:26:12Z Nick Mathewson nickm@torproject.org 2024-06-12T15:26:12Z urn:sha1:8a7e0b6225a1a70803457f4cd13bda0c4b47f024 This patch removes files from dir_blobs if they are not referenced from the database, or if their filenames are not valid UTF-8. (If they were not valid UTF-8, we wouldn't have put them in our database.) To ensure that there can't be any race conditions, we only do this when the file is a bit old. dirmgr: create temporary testing stores with correct paths. 2024-06-12T15:12:01Z Nick Mathewson nickm@torproject.org 2024-06-12T15:12:01Z urn:sha1:06f9af078639d650df6c9b7add640b95cf772368 Previously, we were putting an (optional) db.sql file and our blobs into the same path, which is not what we do outside of our tests. dirmgr::storage: Enable foreign keys on our sqlite connections. 2024-06-12T14:19:36Z Nick Mathewson nickm@torproject.org 2024-06-12T14:19:36Z urn:sha1:16f8757cc5173788563931c575b507a009ed0f28 Without this, "ON DELETE CASCADE" will do nothing. Part of fixing #1466. dirmgr::storage: Treat a missing blob file as an absent object. 2024-06-12T14:18:20Z Nick Mathewson nickm@torproject.org 2024-06-12T13:51:17Z urn:sha1:8801c121ad79a7a59058aef69eff70c9537df1ee Previously it was counted as a hard error, which would cause an absolute failure to start if a blob file had been deleted improperly -- for example, by a renegade cache-cleaner that had decided to remove the largest files it could find. Upon encountering a missing blob, we remove it from the database as well: if we did not, then unavailable consensuses could still cause us to try to fetch consensus diffs, because their rows would still be present. Fixes #1466. Mark tor_dirmgr::storage::Store::consensus_by_meta cfg(test) 2024-04-25T14:22:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-04-24T18:04:09Z urn:sha1:cae1a320027aefbbcefcccabd18fba11f5ecfba6 This seems to be used only in tests, since at least 2022. tor-dirmgr: Work around an apparent regression in `time`. 2023-02-17T19:36:19Z Nick Mathewson nickm@torproject.org 2023-02-17T19:24:31Z urn:sha1:2b515c8d257586f1cd6bc6c74a61ed0de60aab4f Some code in our tests that worked fine with time 0.3.17 no longer works with 0.3.19, despite the semver. See https://github.com/time-rs/time/issues/552 for the upstream bug. Fix a bunch of "needless borrow" warnings on nightly 2022-11-18T15:12:05Z Nick Mathewson nickm@torproject.org 2022-11-18T15:12:05Z urn:sha1:d51162e55b19036528b4fafc1d4b15c8d9d23a04 It looks like, despite a few false starts, they've got this warning right; there weren't any false positives. sqlite cache: Document reasoning about timestamps 2022-11-08T13:00:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-08T13:00:51Z urn:sha1:93a150229a6d3b0fdd93dbd45262a433608dfd06 As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/831#note_2851764 bridge desc: Implement storage functions at the DB layer 2022-11-04T19:08:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-04T19:06:07Z urn:sha1:636bff31937fd5c8e0ce3331872ce1ed2ffc901a