mirrors/arti.git/crates/tor-dirmgr/src/storage, branch arti-v1.1.5mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.52023-02-17T19:36:19Ztor-dirmgr: Work around an apparent regression in `time`.2023-02-17T19:36:19ZNick Mathewsonnickm@torproject.org2023-02-17T19:24:31Zurn:sha1:2b515c8d257586f1cd6bc6c74a61ed0de60aab4f
Some code in our tests that worked fine with time 0.3.17 no
longer works with 0.3.19, despite the semver.
See https://github.com/time-rs/time/issues/552 for the upstream bug.
Fix a bunch of "needless borrow" warnings on nightly2022-11-18T15:12:05ZNick Mathewsonnickm@torproject.org2022-11-18T15:12:05Zurn:sha1:d51162e55b19036528b4fafc1d4b15c8d9d23a04
It looks like, despite a few false starts, they've got this warning
right; there weren't any false positives.
sqlite cache: Document reasoning about timestamps2022-11-08T13:00:51ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-08T13:00:51Zurn:sha1:93a150229a6d3b0fdd93dbd45262a433608dfd06
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/831#note_2851764
bridge desc: Implement storage functions at the DB layer2022-11-04T19:08:32ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-04T19:06:07Zurn:sha1:636bff31937fd5c8e0ce3331872ce1ed2ffc901abridge desc: Implement cache reuse logic and if-modified-since2022-11-04T19:08:32ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-04T19:00:43Zurn:sha1:5bc1d40a2baf20757941727eb0d955b9516b7761
This introduces the new API functions to Store.
But currently they are all no-ops.
So all this machinery doesn't actually do anything.
Also, it changes the API to the mockable downloader, to allow it to
support if-modified-since. So this isn't used either. But it is more
convenient to do this all at once in BridgeDescManager, since care
needs to be taken about the intraction between if-modified-since and
the persistent cache.
bridge desc: Provide a Store to the bridge desc manager2022-11-04T19:02:23ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-04T14:32:24Zurn:sha1:3f3f27193c191bcdecae350d8d64d9e7d0491692
We use the one in the dirmgr. That means that our constructor now has
to take a dirmgr. And, the dirmgr must have a circmgr.
This is all rather odd, TBH.
Add .. to the binding of the return values from setup, as
future-proofing.
The tests now need to provide a Store too. Make the sqlite::new_empty
function pub(crate) so we can use it.
We must retain the _db_tmp_dir, since when it goes away the tmp
directory is deleted and the db goes readonly.
dirmgr sqlite store: Improve schema updates2022-11-04T19:01:24ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-03T18:20:47Zurn:sha1:9a285ec4ad634fee7c48ce664bb359bde20de94e
* Centralise applying the schema updates, in a closure
* Make the schema update SQL texts be in an array so we can loop
* Make the version update statement generic, not cloned-and-hacked
This will make it possible to add another schema version without
error-prone conditions etc.
fix clippy::needless_borrow2022-09-10T12:39:47Ztrinity-1686atrinity@deuxfleurs.fr2022-09-10T12:39:47Zurn:sha1:8e7a904260dfe344eed70a9eef109695544347c1Merge branch 'dirmgr_error_cleanup' into 'main'2022-07-18T14:40:11ZNick Mathewsonnickm@torproject.org2022-07-18T14:40:11Zurn:sha1:8d66f8ecd0b4676e463763432f2a8b19beec1266
Clean up some errors in tor-dirmgr
Closes #521
See merge request tpo/core/arti!628dirmgr: Add a helper to create LockFile errors.2022-07-18T14:10:28ZNick Mathewsonnickm@torproject.org2022-07-18T14:10:28Zurn:sha1:3c424c82d7e2873bde728b74ab6650988b79229b