mirrors/arti.git/crates/tor-dirmgr/src/storage.rs, branch main mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=main 2026-06-10T17:17:33Z arti-client: remove string slices 2026-06-10T17:17:33Z Nick Mathewson nickm@torproject.org 2026-06-10T16:56:50Z urn:sha1:fb22932549237def79c90efef41c2fd3904e91e1 everywhere: Add #[allow(clippy::string_slice)] 2026-06-09T16:02:36Z Clara Engler cve@cve.cx 2026-06-09T16:00:38Z urn:sha1:d0af4abbd7b371f1eade609202a730cd9a1c21d3 This commit adds #[allow(clippy::string_slice)] to all functions in the code where string slices are used, alongside a TODO comment. We do this add the function header to have it consistent, as things like expression based allow's are still experimental. maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. Fix name of clippy lint to unchecked_time_subtraction (2) 2025-11-06T11:28:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-06T11:23:25Z urn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff Run maint/add_warning dirmgr, netdir: Store protocol requirments as soon as they are validated. 2025-04-16T23:06:51Z Nick Mathewson nickm@torproject.org 2025-04-03T15:20:32Z urn:sha1:98f28d0b4c5c2b90ed732ed29d571f71a48c15b4 dirmgr: Backend support for cacheing protocol status. 2025-04-16T23:06:51Z Nick Mathewson nickm@torproject.org 2025-04-03T12:47:41Z urn:sha1:b483b454669b8b0ce93ea52896992d9234e4779d We want to store this separately from the consensus, because we want to access it very early in our load-from-cache process, without checking the consensus that contains it for timeliness. tor-dirmgr: Add some duplicate dead code allows 2024-07-08T10:36:25Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-07-08T10:22:49Z urn:sha1:168cfc2c6e42182a703e51ea61b50dc82a2dfbe4 Sadly, rustc seems to want us to mark this allow in several places. DirMgr: Clarify dead_code status on storage methods. 2024-05-14T14:49:01Z Nick Mathewson nickm@torproject.org 2024-05-14T14:49:01Z urn:sha1:1657ca14bc5763fbd5c04e92ef535b11b4d96f43 Per comments on #1383, we're keeping these methods. This commit replaces the "TODO" comments with comments explaining why it's okay that this methods are unused. Part of #1383. Use the right feature name for an allow(dead_code). 2024-05-07T15:25:33Z Nick Mathewson nickm@torproject.org 2024-05-07T15:25:33Z urn:sha1:94c7503f911795aaf7095dab8484aafd0251776c Mark tor_dirmgr::storage::Store::consensus_by_meta cfg(test) 2024-04-25T14:22:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-04-24T18:04:09Z urn:sha1:cae1a320027aefbbcefcccabd18fba11f5ecfba6 This seems to be used only in tests, since at least 2022.