mirrors/arti.git/crates/tor-dirmgr/src/retry.rs, branch arti-v0.4.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.02022-05-05T09:35:52Zconfig derive attrs: Make builders serde, and validated structs not2022-05-05T09:35:52ZIan Jacksonijackson@chiark.greenend.org.uk2022-05-04T16:45:25Zurn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861
* Builders additionally derive: Debug, Serialize, Deserialize.
* Validated structs no longer derive: Serialize, Deserialize
and all related attributes deleted.
* As a consequence, all the `#[serde(deny_unknown_fields)]`
are gone. That means that right now unknown fields are totally
ignored. This is good for compatibility but poor for useability.
Doing something better here is arti#417, in progress.
* As a consequence, delete tor_dirmgr::retry::default_parallelism.
(The default value was already duplicated into a builder attr.)
Merge branch 'download-schedule' into 'main'2022-04-26T18:47:08ZNick Mathewsonnickm@torproject.org2022-04-26T18:47:08Zurn:sha1:5484bcc21f89d19d30e6351670c36359c132f718
DownloadSchedule: Introduce Builder
See merge request tpo/core/arti!473Make DownloadScheduleBuilder "alternative" defaults pub(crate)2022-04-26T18:01:20ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-26T17:59:10Zurn:sha1:4a32bcd4d3870b2ea5137d6ffeb70bebadcf5ccb
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/473#note_2798464
Fix typo in message2022-04-26T17:40:05ZNick Mathewsonnickm@torproject.org2022-04-26T17:40:05Zurn:sha1:4643e1dd249841f590e441cb9a9e8ef6ba750cbaDownloadSchedule: Rename field to "attempts"2022-04-26T14:16:32ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-26T14:14:26Zurn:sha1:ed718581233b40a159716f34d56a46c58ebee651
This is actually a number of *attempts* not a number of *retries*.
The setter method was already called "attempts".
This chnages the deserialisation of the config.
DownloadSchudule: Have NetworkConfig contain Builders2022-04-26T14:16:32ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-26T13:46:07Zurn:sha1:eb35555330d84ef931dbfd446f5495ff0172b17e
Use sub_builder. We must do something special for defaults.
This involves moving the actual default values for retry_bootstrap and
retry_microdescs into config.rs, since they need to access the fields
of the un-built version of the structure. (An alternative would be to
generate "weak setters" which do not override previous settings, but
derive_builder does not offer to generate them and that seems
overkill.)
DownloadSchedule: Abolish new() method2022-04-26T14:16:32ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-25T18:26:27Zurn:sha1:f4a1e34beebbd891f2a3f1474028ac6ac7f738b2
Instead, everyone should use DownloadScheduleBuilder.
The new() method would in any case be useless in a moment, since we're
going to embed DownloadScheduleBuilder in the NetworkConfig, not
DownloadSchedule.
The call sites in the tests are all about to change again.
DownloadSchedule: tests: Do not try to set parallelism to 02022-04-26T14:16:03ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-26T13:53:05Zurn:sha1:e1d1fe65692e11a5ba7a751e59723ab00e764d43
The current behaviour is to treat 0 as indicating "use the default",
which is quite strange. We are going to get rid of that.
The new way will be to reject zero, during
DownloadScheduleBuilder::build, Add a test case for that.
DownloadSchedule: Provide builder2022-04-26T14:16:03ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-25T18:19:45Zurn:sha1:a720205d35135955025835f13c58a875f898bfd5squash! Bump every crate's edition to 2021.2022-04-25T17:06:26ZNick Mathewsonnickm@torproject.org2022-04-25T16:40:33Zurn:sha1:2f6bc6bdc431fa36de70a167eea777dcf3f60bf2
Remove all `use` statements for `TryFrom` and `TryInto`. These are
now redundant in Rust 2021.